fix: add data-testid to a few other modals description

pull/3281/head
Audric Ackermann 4 months ago
parent 8c41db515e
commit ba3d7f43db
No known key found for this signature in database

@ -1,5 +1,5 @@
import styled from 'styled-components'; import styled from 'styled-components';
import { forwardRef } from 'react'; import { SessionDataTestId } from 'react';
import { Localizer } from './Localizer'; import { Localizer } from './Localizer';
import type { LocalizerComponentProps, LocalizerToken } from '../../types/localizer'; import type { LocalizerComponentProps, LocalizerToken } from '../../types/localizer';
@ -15,13 +15,18 @@ const StyledI18nSubTextContainer = styled('div')`
padding-inline: var(--margins-lg); padding-inline: var(--margins-lg);
`; `;
export const StyledI18nSubText = forwardRef< export const StyledI18nSubText = ({
HTMLSpanElement, className,
LocalizerComponentProps<LocalizerToken> dataTestId,
>(({ className, ...props }) => { localizerProps,
}: {
className?: string;
dataTestId: SessionDataTestId;
localizerProps: LocalizerComponentProps<LocalizerToken>;
}) => {
return ( return (
<StyledI18nSubTextContainer className={className}> <StyledI18nSubTextContainer className={className} data-testid={dataTestId}>
<Localizer {...props} /> <Localizer {...localizerProps} />
</StyledI18nSubTextContainer> </StyledI18nSubTextContainer>
); );
}); };

@ -47,7 +47,10 @@ export function OpenUrlModal(props: OpenUrlModalState) {
> >
<div className="session-modal__centered"> <div className="session-modal__centered">
<StyledScrollDescriptionContainer> <StyledScrollDescriptionContainer>
<StyledI18nSubText token="urlOpenDescription" asTag="span" args={{ url }} /> <StyledI18nSubText
localizerProps={{ token: 'urlOpenDescription', asTag: 'span', args: { url } }}
dataTestId="modal-description"
/>
</StyledScrollDescriptionContainer> </StyledScrollDescriptionContainer>
</div> </div>
<SpacerMD /> <SpacerMD />

@ -85,7 +85,10 @@ export const QuitModal = (props: SessionConfirmDialogProps) => {
style={modalStyle} style={modalStyle}
> >
<SpacerLG /> <SpacerLG />
<StyledI18nSubText {...i18nMessage}></StyledI18nSubText> <StyledI18nSubText
localizerProps={i18nMessage}
dataTestId="modal-description"
></StyledI18nSubText>
<SpacerLG /> <SpacerLG />
</Flex> </Flex>
) : null} ) : null}

@ -132,7 +132,7 @@ export const SessionConfirm = (props: SessionConfirmDialogProps) => {
<div className="session-modal__centered"> <div className="session-modal__centered">
{i18nMessage ? ( {i18nMessage ? (
<StyledI18nSubText {...i18nMessage} data-testid="modal-description" /> <StyledI18nSubText localizerProps={i18nMessage} dataTestId="modal-description" />
) : null} ) : null}
{radioOptions && chosenOption !== '' ? ( {radioOptions && chosenOption !== '' ? (
<SessionRadioGroup <SessionRadioGroup

Loading…
Cancel
Save