Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								7bfb66b13b 
								
							
								 
							
						 
						
							
							
								
								processVerifiedMessage: Archive all sessions when key changes  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								827addf628 
								
							
								 
							
						 
						
							
							
								
								Log on receipt of verified sync after we've processed the state  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								d7054f4b63 
								
							
								 
							
						 
						
							
							
								
								Archive sessions whenever an identity key changes  
							
							 
							
							... 
							
							
							
							Sessions established with the previous identity should no longer be used for
sending, so we should close them.
Since we've added this call to saveIdentity, we can omit the call to it after
profile fetches.
// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								0056cbefc1 
								
							
								 
							
						 
						
							
							
								
								processVerifiedMessage: Trigger keychange event when key differs  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								0db2ef9e7f 
								
							
								 
							
						 
						
							
							
								
								Refactor: combine Conversation.setVerified/setVerifiedDefault  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								d1fa28b706 
								
							
								 
							
						 
						
							
							
								
								Object.assign -> _.extend(), for to make Chrome 45 and below work  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								1e8ae774a2 
								
							
								 
							
						 
						
							
							
								
								Differentiate between local and remote trust decisions  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								20f4d48991 
								
							
								 
							
						 
						
							
							
								
								Protos: Move to latest iteration of verification protos  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								3360f65fac 
								
							
								 
							
						 
						
							
							
								
								Protos: Update spacing to match libsignal-service-java  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								3acfda3a56 
								
							
								 
							
						 
						
							
							
								
								Archive sessions on key changes after profile fetch  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								4232f5711c 
								
							
								 
							
						 
						
							
							
								
								Handle identity key change errors on encrypt  
							
							 
							
							... 
							
							
							
							We need to capture key change errors from the protocol library when we call
encrypt. Previously we would only see these on session init.
// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								5d5805526a 
								
							
								 
							
						 
						
							
							
								
								Fix a test  
							
							 
							
							... 
							
							
							
							Set the timestamp on the record to current time to ensure that
nonblockingApproval will be required.
// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								f15fadbb4d 
								
							
								 
							
						 
						
							
							
								
								Test processVerifiedMessage  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								044e1560e0 
								
							
								 
							
						 
						
							
							
								
								Test new setVerified behavior  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								4f2f622598 
								
							
								 
							
						 
						
							
							
								
								Apply special handling to verification sync messages  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								1614a6f1b8 
								
							
								 
							
						 
						
							
							
								
								Add special handling for verification sync  
							
							 
							
							... 
							
							
							
							processVerifiedMessage checks the current state of the database against the
identity key from an incoming verification sync message to determine whether or
how to update our local record.
When syncing a DEFAULT status and we have no local record, it's a no-op, but
we'll log it.
When syncing a DEFAULT status and we have non-default record with the same key,
mark it as default.
When syncing a VERIFIED status and either:
  1. we have no key on record,
  2. we have have a different key on record, or
  3. we have the same key on record, but not verified
mark it as verified.
Otherwise do nothing.
References: https://github.com/WhisperSystems/Signal-Android/blob/master/src/org/thoughtcrime/securesms/util/IdentityUtil.java#L129 
// FREEBIE
Ensure processVerified resolves 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								c60919ca0e 
								
							
								 
							
						 
						
							
							
								
								Update setVerified to take an optional key argument  
							
							 
							
							... 
							
							
							
							If specified, the existing local key must match the given one or we will not
update the record.
// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								33b4d398d6 
								
							
								 
							
						 
						
							
							
								
								Fix indentation  
							
							 
							
							
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								1e594e79c1 
								
							
								 
							
						 
						
							
							
								
								Fix test page template  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								2778148179 
								
							
								 
							
						 
						
							
							
								
								Move unverified banner text to match Android  
							
							 
							
							... 
							
							
							
							Longer, so it will wrap more often. We have the right alignment and
padding in place, though, so it looks pretty reasonable.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								12d7fb3b74 
								
							
								 
							
						 
						
							
							
								
								Left-align confirmation dialog text, explain more on 'send anyway'  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								16433d661a 
								
							
								 
							
						 
						
							
							
								
								Show call to action on group member list when verifying  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								31bf05e14a 
								
							
								 
							
						 
						
							
							
								
								Add verified state summary to top of safety number screen  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								d462108e83 
								
							
								 
							
						 
						
							
							
								
								Replace warning icon with a smaller file so it scales down better  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								11372b4e00 
								
							
								 
							
						 
						
							
							
								
								Add icons for keychange and expiration timer in-conversation items  
							
							 
							
							... 
							
							
							
							The shield matches the Android app's key change notification, and the
clock icon was easy to do and makes it easier to visually distinguish
those items in the conversation history.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								c714fb6dbf 
								
							
								 
							
						 
						
							
							
								
								Shadow/icon/blue for banner, better verify advisories in dark theme  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								1d7cbc14fd 
								
							
								 
							
						 
						
							
							
								
								Fix a couple bind()) issues when getting verified state  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								b0dbecb4e2 
								
							
								 
							
						 
						
							
							
								
								Check trust store for identity key information on every new message  
							
							 
							
							... 
							
							
							
							It's debounced so it doesn't go too crazy.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								782c484680 
								
							
								 
							
						 
						
							
							
								
								Check trust store for latest identity key info before sending  
							
							 
							
							... 
							
							
							
							We definitely want the latest information from our local database before
attempting to send.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								fc39241003 
								
							
								 
							
						 
						
							
							
								
								Ensure that we pull verified state only after getting profiles  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								4a1dc46ab3 
								
							
								 
							
						 
						
							
							
								
								Fixes to get local verification and sync messages working  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								c43d96904d 
								
							
								 
							
						 
						
							
							
								
								Move to the real verify/trust APIs  
							
							 
							
							... 
							
							
							
							This wires up verification sync messages, verification and trust checks
to the trust store instead of using mocked data.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								lilia
							
						 
						
							 
							
							
							
								
							
								52481d1d13 
								
							
								 
							
						 
						
							
							
								
								Support for sending and receiving verification sync messages  
							
							 
							
							... 
							
							
							
							This adds a new method to message sender for sending verification sync messages
and a new event to message receiver representing incoming verification sync
messages. Currently the event handler just logs the message.
// FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								475d607fd0 
								
							
								 
							
						 
						
							
							
								
								Prepare for verification sync messages: receiver, ready to send  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								aebf4b32d6 
								
							
								 
							
						 
						
							
							
								
								Conversation.updateLastMessage: fix indent, use of null message  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								36c28296e9 
								
							
								 
							
						 
						
							
							
								
								Remove extraneous logging  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								9b864c8675 
								
							
								 
							
						 
						
							
							
								
								Re-render verified change conversation items when convo changes  
							
							 
							
							... 
							
							
							
							If the contact's name changes, for example.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								1cf9289b1a 
								
							
								 
							
						 
						
							
							
								
								Add items to conversation history when user verifies/unverifies  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								02973372aa 
								
							
								 
							
						 
						
							
							
								
								Update strings to use 'Click to show' not 'Click to verify'  
							
							 
							
							... 
							
							
							
							'Click to verify' suggests immediate action. We don't want that.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								a827334c3e 
								
							
								 
							
						 
						
							
							
								
								Allow re-send of messages in msg detail view on OutgoingKeyError  
							
							 
							
							... 
							
							
							
							We also show more errors than we used to in the MessageDetail screen
to help make it clear what is happening, and why the user would need to
re-send.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								47c5142a83 
								
							
								 
							
						 
						
							
							
								
								Replace unicode check with new svg icon  
							
							 
							
							... 
							
							
							
							A good bit of CSS was required to keep the text color changing along
with the text it is nestled within.
Also: took this opportunity to increase the contrast of the number and
verified section right under the contact name in the group members view.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								688cae6374 
								
							
								 
							
						 
						
							
							
								
								Remove empty string class passed to contact template  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								8264f3ba33 
								
							
								 
							
						 
						
							
							
								
								Make the term 'Verified' fully localizable  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								e9968c3118 
								
							
								 
							
						 
						
							
							
								
								Remove comments after NewGroupUpdateView investigation  
							
							 
							
							... 
							
							
							
							It doesn't run today - it depends on RecipientsInputView, which depends
on Backbone.TypeaheadCollection which doesn't currently exist in the
product.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								3d61f87d86 
								
							
								 
							
						 
						
							
							
								
								Remove isVerified string from messages.json - don't use  
							
							 
							
							... 
							
							
							
							We don't need this extra string for the safety number screen, since the
header includes the user's verified status.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								caa92c9312 
								
							
								 
							
						 
						
							
							
								
								Reintroduce outline around confirmation dialog buttons  
							
							 
							
							... 
							
							
							
							It was very hard to tell which button was selected without the standard
outline.
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								db2620af0a 
								
							
								 
							
						 
						
							
							
								
								Safety Number screen: make verify button like other buttons  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								8d29cb9830 
								
							
								 
							
						 
						
							
							
								
								Prevent access to Safety Number when talking to yourself  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								c7e385eb38 
								
							
								 
							
						 
						
							
							
								
								Remove 'safety number approval' option from settings dialog  
							
							 
							
							... 
							
							
							
							Also sync templates in test/index.html and background.html
FREEBIE 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Scott Nonnenberg
							
						 
						
							 
							
							
							
								
							
								9204188aa3 
								
							
								 
							
						 
						
							
							
								
								A bit of cleanup after some early code review  
							
							 
							
							... 
							
							
							
							FREEBIE 
							
						 
						
							8 years ago