remove unused preKeyLastResort

pull/1/head
Michael Kirk 7 years ago
parent 966db1bd49
commit 1eb05c1d01

@ -146,7 +146,6 @@ static const NSUInteger kMaxPrekeyUpdateFailureCount = 5;
NSString *description; NSString *description;
if (modeCopy == RefreshPreKeysMode_SignedAndOneTime) { if (modeCopy == RefreshPreKeysMode_SignedAndOneTime) {
description = @"signed and one-time prekeys"; description = @"signed and one-time prekeys";
PreKeyRecord *lastResortPreKey = [primaryStorage getOrGenerateLastResortKey];
preKeys = [primaryStorage generatePreKeyRecords]; preKeys = [primaryStorage generatePreKeyRecords];
// Store the new one-time keys immediately, before they are sent to the // Store the new one-time keys immediately, before they are sent to the
// service to prevent race conditions and other edge cases. // service to prevent race conditions and other edge cases.
@ -154,8 +153,7 @@ static const NSUInteger kMaxPrekeyUpdateFailureCount = 5;
request = [OWSRequestFactory registerPrekeysRequestWithPrekeyArray:preKeys request = [OWSRequestFactory registerPrekeysRequestWithPrekeyArray:preKeys
identityKey:identityKeyPair.publicKey identityKey:identityKeyPair.publicKey
signedPreKey:signedPreKey signedPreKey:signedPreKey];
preKeyLastResort:lastResortPreKey];
} else { } else {
description = @"just signed prekey"; description = @"just signed prekey";
request = [OWSRequestFactory registerSignedPrekeyRequestWithSignedPreKeyRecord:signedPreKey]; request = [OWSRequestFactory registerSignedPrekeyRequestWithSignedPreKeyRecord:signedPreKey];

@ -67,8 +67,7 @@ typedef NS_ENUM(NSUInteger, TSVerificationTransport) { TSVerificationTransportVo
+ (TSRequest *)registerPrekeysRequestWithPrekeyArray:(NSArray *)prekeys + (TSRequest *)registerPrekeysRequestWithPrekeyArray:(NSArray *)prekeys
identityKey:(NSData *)identityKeyPublic identityKey:(NSData *)identityKeyPublic
signedPreKey:(SignedPreKeyRecord *)signedPreKey signedPreKey:(SignedPreKeyRecord *)signedPreKey;
preKeyLastResort:(PreKeyRecord *)preKeyLastResort;
+ (TSRequest *)remoteAttestationRequest:(ECKeyPair *)keyPair + (TSRequest *)remoteAttestationRequest:(ECKeyPair *)keyPair
enclaveId:(NSString *)enclaveId enclaveId:(NSString *)enclaveId

@ -235,12 +235,10 @@ NS_ASSUME_NONNULL_BEGIN
+ (TSRequest *)registerPrekeysRequestWithPrekeyArray:(NSArray *)prekeys + (TSRequest *)registerPrekeysRequestWithPrekeyArray:(NSArray *)prekeys
identityKey:(NSData *)identityKeyPublic identityKey:(NSData *)identityKeyPublic
signedPreKey:(SignedPreKeyRecord *)signedPreKey signedPreKey:(SignedPreKeyRecord *)signedPreKey
preKeyLastResort:(PreKeyRecord *)preKeyLastResort
{ {
OWSAssertDebug(prekeys.count > 0); OWSAssertDebug(prekeys.count > 0);
OWSAssertDebug(identityKeyPublic.length > 0); OWSAssertDebug(identityKeyPublic.length > 0);
OWSAssertDebug(signedPreKey); OWSAssertDebug(signedPreKey);
OWSAssertDebug(preKeyLastResort);
NSString *path = textSecureKeysAPI; NSString *path = textSecureKeysAPI;
NSString *publicIdentityKey = [[identityKeyPublic prependKeyType] base64EncodedStringWithOptions:0]; NSString *publicIdentityKey = [[identityKeyPublic prependKeyType] base64EncodedStringWithOptions:0];
@ -252,7 +250,6 @@ NS_ASSUME_NONNULL_BEGIN
method:@"PUT" method:@"PUT"
parameters:@{ parameters:@{
@"preKeys" : serializedPrekeyList, @"preKeys" : serializedPrekeyList,
@"lastResortKey" : [self dictionaryFromPreKey:preKeyLastResort],
@"signedPreKey" : [self dictionaryFromSignedPreKey:signedPreKey], @"signedPreKey" : [self dictionaryFromSignedPreKey:signedPreKey],
@"identityKey" : publicIdentityKey @"identityKey" : publicIdentityKey
}]; }];

@ -7,8 +7,7 @@
@interface OWSPrimaryStorage (PreKeyStore) <PreKeyStore> @interface OWSPrimaryStorage (PreKeyStore) <PreKeyStore>
- (NSArray *)generatePreKeyRecords; - (NSArray<PreKeyRecord *> *)generatePreKeyRecords;
- (PreKeyRecord *)getOrGenerateLastResortKey;
- (void)storePreKeyRecords:(NSArray *)preKeyRecords; - (void)storePreKeyRecords:(NSArray *)preKeyRecords;
@end @end

@ -16,19 +16,7 @@
@implementation OWSPrimaryStorage (PreKeyStore) @implementation OWSPrimaryStorage (PreKeyStore)
- (PreKeyRecord *)getOrGenerateLastResortKey - (NSArray<PreKeyRecord *> *)generatePreKeyRecords;
{
if ([self containsPreKey:kPreKeyOfLastResortId]) {
return [self loadPreKey:kPreKeyOfLastResortId];
} else {
PreKeyRecord *lastResort =
[[PreKeyRecord alloc] initWithId:kPreKeyOfLastResortId keyPair:[Curve25519 generateKeyPair]];
[self storePreKey:kPreKeyOfLastResortId preKeyRecord:lastResort];
return lastResort;
}
}
- (NSArray *)generatePreKeyRecords
{ {
NSMutableArray *preKeyRecords = [NSMutableArray array]; NSMutableArray *preKeyRecords = [NSMutableArray array];

Loading…
Cancel
Save