Hide contact editing features on iOS8

// FREEBIE

Signal/src/ViewControllers/ContactsViewHelper.m

@@ -303,6 +303,13 @@ NS_ASSUME_NONNULL_BEGIN
 {
     SignalAccount *signalAccount = [self signalAccountForRecipientId:recipientId];
 
+    if (!self.contactsManager.supportsContactEditing) {
+        DDLogError(@"%@ Contact editing not supported.", self.tag);
+        // Should not expose UI that lets the user get here.
+        OWSAssert(NO);
+        return;
+    }
+
     if (!self.contactsManager.isSystemContactsAuthorized) {
         UIAlertController *alertController = [UIAlertController
             alertControllerWithTitle:NSLocalizedString(@"EDIT_CONTACT_WITHOUT_CONTACTS_PERMISSION_ALERT_TITLE", comment
@@ -384,6 +391,18 @@ NS_ASSUME_NONNULL_BEGIN
     [UIUtil applyDefaultSystemAppearence];
 }
 
+#pragma mark - Logging
+
++ (NSString *)tag
+{
+    return [NSString stringWithFormat:@"[%@]", self.class];
+}
+
+- (NSString *)tag
+{
+    return self.class.tag;
+}
+
 @end
 
 NS_ASSUME_NONNULL_END

Signal/src/ViewControllers/OWSConversationSettingsTableViewController.m

@@ -136,7 +136,7 @@ NS_ASSUME_NONNULL_BEGIN
 {
     OWSAssert(self.thread);
 
-    if ([self.thread isKindOfClass:[TSContactThread class]]) {
+    if ([self.thread isKindOfClass:[TSContactThread class]] && self.contactsManager.supportsContactEditing) {
         self.navigationItem.rightBarButtonItem =
             [[UIBarButtonItem alloc] initWithTitle:NSLocalizedString(@"EDIT_TXT", nil)
                                              style:UIBarButtonItemStylePlain
@@ -677,6 +677,10 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (void)presentContactViewController
 {
+    if (!self.contactsManager.supportsContactEditing) {
+        DDLogWarn(@"%@ Contact editing not supported", self.tag);
+        return;
+    }
     if (![self.thread isKindOfClass:[TSContactThread class]]) {
         DDLogError(@"%@ unexpected thread: %@ in %s", self.tag, self.thread, __PRETTY_FUNCTION__);
         OWSAssert(NO);

Signal/src/ViewControllers/ShowGroupMembersViewController.m

@@ -156,15 +156,18 @@ NS_ASSUME_NONNULL_BEGIN
     UIAlertController *actionSheetController =
         [UIAlertController alertControllerWithTitle:nil message:nil preferredStyle:UIAlertControllerStyleActionSheet];
 
-    NSString *contactInfoTitle = signalAccount
+    if (self.contactsViewHelper.contactsManager.supportsContactEditing) {
-        ? NSLocalizedString(@"GROUP_MEMBERS_VIEW_CONTACT_INFO", @"Button label for the 'show contact info' button")
+        NSString *contactInfoTitle = signalAccount
-        : NSLocalizedString(
+            ? NSLocalizedString(@"GROUP_MEMBERS_VIEW_CONTACT_INFO", @"Button label for the 'show contact info' button")
-              @"GROUP_MEMBERS_ADD_CONTACT_INFO", @"Button label to add information to an unknown contact");
+            : NSLocalizedString(
-    [actionSheetController addAction:[UIAlertAction actionWithTitle:contactInfoTitle
+                  @"GROUP_MEMBERS_ADD_CONTACT_INFO", @"Button label to add information to an unknown contact");
-                                                              style:UIAlertActionStyleDefault
+        [actionSheetController addAction:[UIAlertAction actionWithTitle:contactInfoTitle
-                                                            handler:^(UIAlertAction *_Nonnull action) {
+                                                                  style:UIAlertActionStyleDefault
-                                                                [self showContactInfoViewForRecipientId:recipientId];
+                                                                handler:^(UIAlertAction *_Nonnull action) {
-                                                            }]];
+                                                                    [self
+                                                                        showContactInfoViewForRecipientId:recipientId];
+                                                                }]];
+    }
 
     BOOL isBlocked;
     if (signalAccount) {

Signal/src/contact/OWSContactsManager.h

@@ -36,6 +36,8 @@ extern NSString *const OWSContactsManagerSignalAccountsDidChangeNotification;
 // Must call `requestSystemContactsOnce` before accessing this method
 @property (nonatomic, readonly) BOOL isSystemContactsAuthorized;
 
+@property (nonatomic, readonly) BOOL supportsContactEditing;
+
 // Request systems contacts and start syncing changes. The user will see an alert
 // if they haven't previously.
 - (void)requestSystemContactsOnce;

Signal/src/contact/OWSContactsManager.m

@@ -73,6 +73,11 @@ NSString *const OWSContactsManagerSignalAccountsDidChangeNotification =
     return self.systemContactsFetcher.isAuthorized;
 }
 
+- (BOOL)supportsContactEditing
+{
+    return self.systemContactsFetcher.supportsContactEditing;
+}
+
 #pragma mark SystemContactsFetcherDelegate
 
 - (void)systemContactsFetcher:(SystemContactsFetcher *)systemsContactsFetcher

Signal/src/contact/SystemContactsFetcher.swift

@@ -13,6 +13,7 @@ enum Result<T, ErrorType> {
 
 protocol ContactStoreAdaptee {
     var authorizationStatus: ContactStoreAuthorizationStatus { get }
+    var supportsContactEditing: Bool { get }
     func requestAccess(completionHandler: @escaping (Bool, Error?) -> Void)
     func fetchContacts() -> Result<[Contact], Error>
     func startObservingChanges(changeHandler: @escaping () -> Void)
@@ -24,6 +25,7 @@ class ContactsFrameworkContactStoreAdaptee: ContactStoreAdaptee {
     private let contactStore = CNContactStore()
     private var changeHandler: (() -> Void)?
     private var initializedObserver = false
+    let supportsContactEditing = true
 
     private let allowedContactKeys: [CNKeyDescriptor] = [
         CNContactFormatter.descriptorForRequiredKeys(for: .fullName),
@@ -95,6 +97,7 @@ class AddressBookContactStoreAdaptee: ContactStoreAdaptee {
 
     private var addressBook: ABAddressBook = ABAddressBookCreateWithOptions(nil, nil).takeRetainedValue()
     private var changeHandler: (() -> Void)?
+    let supportsContactEditing = false
 
     var authorizationStatus: ContactStoreAuthorizationStatus {
         switch ABAddressBookGetAuthorizationStatus() {
@@ -265,6 +268,7 @@ enum ContactStoreAuthorizationStatus {
 }
 
 class ContactStoreAdapter: ContactStoreAdaptee {
+
     let adaptee: ContactStoreAdaptee
 
     init() {
@@ -275,6 +279,10 @@ class ContactStoreAdapter: ContactStoreAdaptee {
         }
     }
 
+    var supportsContactEditing: Bool {
+        return self.adaptee.supportsContactEditing
+    }
+
     var authorizationStatus: ContactStoreAuthorizationStatus {
         return self.adaptee.authorizationStatus
     }