Only enter batch select mode if user uses "add more" button.

pull/1/head
Matthew Chen 6 years ago
parent 3e36dcf91f
commit 6b100e80e2

@ -319,9 +319,6 @@ class ImagePickerGridController: UICollectionViewController, PhotoLibraryDelegat
private func didComplete(withAttachments attachments: [SignalAttachment]) { private func didComplete(withAttachments attachments: [SignalAttachment]) {
AssertIsOnMainThread() AssertIsOnMainThread()
// If we re-enter image picking, do so in batch mode.
isInBatchSelectMode = true
for attachment in attachments { for attachment in attachments {
guard let assetId = attachment.assetId else { guard let assetId = attachment.assetId else {
owsFailDebug("Attachment is missing asset id.") owsFailDebug("Attachment is missing asset id.")
@ -376,17 +373,6 @@ class ImagePickerGridController: UICollectionViewController, PhotoLibraryDelegat
self.doneButton.isEnabled = false self.doneButton.isEnabled = false
} }
@objc
func didCancelSelect(_ sender: Any) {
endSelectMode()
}
func endSelectMode() {
isInBatchSelectMode = false
deselectAnySelected()
}
func deselectAnySelected() { func deselectAnySelected() {
guard let collectionView = self.collectionView else { guard let collectionView = self.collectionView else {
owsFailDebug("collectionView was unexpectedly nil") owsFailDebug("collectionView was unexpectedly nil")
@ -520,6 +506,11 @@ class ImagePickerGridController: UICollectionViewController, PhotoLibraryDelegat
override func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) { override func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
if !isInBatchSelectMode {
// Clear previous selection, if any.
selectedIds.removeAllObjects()
}
let asset = photoCollectionContents.asset(at: indexPath.item) let asset = photoCollectionContents.asset(at: indexPath.item)
let assetId = asset.localIdentifier let assetId = asset.localIdentifier
selectedIds.add(assetId) selectedIds.add(assetId)
@ -577,6 +568,9 @@ class ImagePickerGridController: UICollectionViewController, PhotoLibraryDelegat
} }
func attachmentApproval(_ attachmentApproval: AttachmentApprovalViewController, addMoreToAttachments attachments: [SignalAttachment]) { func attachmentApproval(_ attachmentApproval: AttachmentApprovalViewController, addMoreToAttachments attachments: [SignalAttachment]) {
// If we re-enter image picking via "add more" button, do so in batch mode.
isInBatchSelectMode = true
navigationController?.popToViewController(self, animated: true) navigationController?.popToViewController(self, animated: true)
} }

Loading…
Cancel
Save