keejef
/
session-ios
mirror of https://github.com/oxen-io/session-ios
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix link preview tests.

Browse Source
pull/1/head
Matthew Chen 6 years ago
parent aff7d8320e
commit 744d3074ac
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File

2
SignalServiceKit/src/Messages/Interactions/OWSLinkPreview.swift
Unescape Escape View File

@ -167,7 +167,7 @@ public class OWSLinkPreview: MTLModel {
let linkPreview = OWSLinkPreview(urlString: urlString, title: title, imageAttachmentId: imageAttachmentId) let linkPreview = OWSLinkPreview(urlString: urlString, title: title, imageAttachmentId: imageAttachmentId)
guard linkPreview.isValid() else { guard linkPreview.isValid() else {
owsFailDebug("Preview has neither title nor image.") Logger.error("Preview has neither title nor image.")
throw LinkPreviewError.invalidInput throw LinkPreviewError.invalidInput
} }

8
SignalServiceKit/tests/Messages/OWSLinkPreviewTest.swift
Unescape Escape View File

@ -28,7 +28,7 @@ class OWSLinkPreviewTest: SSKBaseTestSwift {
imageAttachmentBuilder.setContentType(OWSMimeTypeImageJpeg) imageAttachmentBuilder.setContentType(OWSMimeTypeImageJpeg)
previewBuilder.setImage(try! imageAttachmentBuilder.build()) previewBuilder.setImage(try! imageAttachmentBuilder.build())
let dataBuilder = SSKProtoDataMessage.builder() let dataBuilder = SSKProtoDataMessage.builder()
dataBuilder.setPreview(try! previewBuilder.build()) dataBuilder.addPreview(try! previewBuilder.build())
self.readWrite { (transaction) in self.readWrite { (transaction) in
XCTAssertNotNil(try! OWSLinkPreview.buildValidatedLinkPreview(dataMessage: try! dataBuilder.build(), XCTAssertNotNil(try! OWSLinkPreview.buildValidatedLinkPreview(dataMessage: try! dataBuilder.build(),
@ -43,7 +43,7 @@ class OWSLinkPreviewTest: SSKBaseTestSwift {
let previewBuilder = SSKProtoDataMessagePreview.builder(url: url) let previewBuilder = SSKProtoDataMessagePreview.builder(url: url)
previewBuilder.setTitle("Some Youtube Video") previewBuilder.setTitle("Some Youtube Video")
let dataBuilder = SSKProtoDataMessage.builder() let dataBuilder = SSKProtoDataMessage.builder()
dataBuilder.setPreview(try! previewBuilder.build()) dataBuilder.addPreview(try! previewBuilder.build())
self.readWrite { (transaction) in self.readWrite { (transaction) in
XCTAssertNotNil(try! OWSLinkPreview.buildValidatedLinkPreview(dataMessage: try! dataBuilder.build(), XCTAssertNotNil(try! OWSLinkPreview.buildValidatedLinkPreview(dataMessage: try! dataBuilder.build(),
@ -61,7 +61,7 @@ class OWSLinkPreviewTest: SSKBaseTestSwift {
imageAttachmentBuilder.setContentType(OWSMimeTypeImageJpeg) imageAttachmentBuilder.setContentType(OWSMimeTypeImageJpeg)
previewBuilder.setImage(try! imageAttachmentBuilder.build()) previewBuilder.setImage(try! imageAttachmentBuilder.build())
let dataBuilder = SSKProtoDataMessage.builder() let dataBuilder = SSKProtoDataMessage.builder()
dataBuilder.setPreview(try! previewBuilder.build()) dataBuilder.addPreview(try! previewBuilder.build())
self.readWrite { (transaction) in self.readWrite { (transaction) in
XCTAssertNotNil(try! OWSLinkPreview.buildValidatedLinkPreview(dataMessage: try! dataBuilder.build(), XCTAssertNotNil(try! OWSLinkPreview.buildValidatedLinkPreview(dataMessage: try! dataBuilder.build(),
@ -75,7 +75,7 @@ class OWSLinkPreviewTest: SSKBaseTestSwift {
let body = "\(url)" let body = "\(url)"
let previewBuilder = SSKProtoDataMessagePreview.builder(url: url) let previewBuilder = SSKProtoDataMessagePreview.builder(url: url)
let dataBuilder = SSKProtoDataMessage.builder() let dataBuilder = SSKProtoDataMessage.builder()
dataBuilder.setPreview(try! previewBuilder.build()) dataBuilder.addPreview(try! previewBuilder.build())
self.readWrite { (transaction) in self.readWrite { (transaction) in
do { do {

Write Preview
Loading…
Cancel
Save