Respond to CR.

pull/1/head
Matthew Chen 8 years ago
parent cac85508cc
commit 822aa64b14

@ -10,8 +10,6 @@ NS_ASSUME_NONNULL_BEGIN
+ (NSString *)cellReuseIdentifier; + (NSString *)cellReuseIdentifier;
+ (UIFont *)defaultTextMessageFont;
@end @end
NS_ASSUME_NONNULL_END NS_ASSUME_NONNULL_END

@ -147,16 +147,11 @@ NS_ASSUME_NONNULL_BEGIN
return NSStringFromClass([self class]); return NSStringFromClass([self class]);
} }
+ (UIFont *)defaultTextMessageFont
{
return [UIFont ows_dynamicTypeBodyFont];
}
- (UIFont *)textMessageFont - (UIFont *)textMessageFont
{ {
OWSAssert(DisplayableText.kMaxJumbomojiCount == 5); OWSAssert(DisplayableText.kMaxJumbomojiCount == 5);
CGFloat basePointSize = self.class.defaultTextMessageFont.pointSize; CGFloat basePointSize = [UIFont ows_dynamicTypeBodyFont].pointSize;
switch (self.displayableBodyText.jumbomojiCount) { switch (self.displayableBodyText.jumbomojiCount) {
case 0: case 0:
break; break;

@ -20,9 +20,11 @@ NS_ASSUME_NONNULL_BEGIN
// Measurement // Measurement
- (CGSize)sizeForMaxWidth:(CGFloat)maxWidth; - (CGSize)sizeForMaxWidth:(CGFloat)maxWidth;
// Factory method for "message bubble" views.
+ (OWSQuotedMessageView *)quotedMessageViewForConversation:(TSQuotedMessage *)quotedMessage + (OWSQuotedMessageView *)quotedMessageViewForConversation:(TSQuotedMessage *)quotedMessage
displayableQuotedText:(nullable DisplayableText *)displayableQuotedText; displayableQuotedText:(nullable DisplayableText *)displayableQuotedText;
// Factory method for "message compose" views.
+ (OWSQuotedMessageView *)quotedMessageViewForPreview:(TSQuotedMessage *)quotedMessage; + (OWSQuotedMessageView *)quotedMessageViewForPreview:(TSQuotedMessage *)quotedMessage;
@end @end

@ -6,7 +6,6 @@
#import "ConversationViewItem.h" #import "ConversationViewItem.h"
#import "Environment.h" #import "Environment.h"
#import "OWSBubbleStrokeView.h" #import "OWSBubbleStrokeView.h"
#import "OWSMessageCell.h"
#import "Signal-Swift.h" #import "Signal-Swift.h"
#import <SignalMessaging/OWSContactsManager.h> #import <SignalMessaging/OWSContactsManager.h>
#import <SignalMessaging/SignalMessaging-Swift.h> #import <SignalMessaging/SignalMessaging-Swift.h>
@ -68,7 +67,7 @@ NS_ASSUME_NONNULL_BEGIN
_quotedMessage = quotedMessage; _quotedMessage = quotedMessage;
_displayableQuotedText = displayableQuotedText; _displayableQuotedText = displayableQuotedText;
_textMessageFont = OWSMessageCell.defaultTextMessageFont; _textMessageFont = [UIFont ows_dynamicTypeBodyFont];
return self; return self;
} }
@ -76,13 +75,13 @@ NS_ASSUME_NONNULL_BEGIN
- (BOOL)hasQuotedAttachment - (BOOL)hasQuotedAttachment
{ {
return (self.quotedMessage.contentType.length > 0 return (self.quotedMessage.contentType.length > 0
&& ![NSObject isNullableObject:self.quotedMessage.contentType equalTo:OWSMimeTypeOversizeTextMessage]); && ![OWSMimeTypeOversizeTextMessage isEqualToString:self.quotedMessage.contentType]);
} }
- (BOOL)hasQuotedAttachmentThumbnail - (BOOL)hasQuotedAttachmentThumbnail
{ {
return (self.quotedMessage.contentType.length > 0 return (self.quotedMessage.contentType.length > 0
&& ![NSObject isNullableObject:self.quotedMessage.contentType equalTo:OWSMimeTypeOversizeTextMessage] && && ![OWSMimeTypeOversizeTextMessage isEqualToString:self.quotedMessage.contentType] &&
[TSAttachmentStream hasThumbnailForMimeType:self.quotedMessage.contentType]); [TSAttachmentStream hasThumbnailForMimeType:self.quotedMessage.contentType]);
} }

@ -18,6 +18,8 @@ NS_ASSUME_NONNULL_BEGIN
+ (UIFont *)ows_boldFontWithSize:(CGFloat)size; + (UIFont *)ows_boldFontWithSize:(CGFloat)size;
+ (UIFont *)ows_dynamicTypeBodyFont:(CGFloat)size;
#pragma mark - Icon Fonts #pragma mark - Icon Fonts
+ (UIFont *)ows_fontAwesomeFont:(CGFloat)size; + (UIFont *)ows_fontAwesomeFont:(CGFloat)size;

@ -33,6 +33,11 @@ NS_ASSUME_NONNULL_BEGIN
return [UIFont boldSystemFontOfSize:size]; return [UIFont boldSystemFontOfSize:size];
} }
+ (UIFont *)ows_dynamicTypeBodyFont:(CGFloat)size
{
return [UIFont ows_dynamicTypeBodyFont];
}
#pragma mark - Icon Fonts #pragma mark - Icon Fonts
+ (UIFont *)ows_fontAwesomeFont:(CGFloat)size + (UIFont *)ows_fontAwesomeFont:(CGFloat)size

Loading…
Cancel
Save