Update profile on service.

// FREEBIE

Signal/src/Profiles/OWSProfileManager.m

@@ -10,7 +10,7 @@
 #import <SignalServiceKit/OWSMessageSender.h>
 #import <SignalServiceKit/SecurityUtils.h>
 #import <SignalServiceKit/TSGroupThread.h>
-#import <SignalServiceKit/TSStorageManager.h>
+#import <SignalServiceKit/TSSetProfileRequest.h>
 #import <SignalServiceKit/TSStorageManager.h>
 #import <SignalServiceKit/TSThread.h>
 #import <SignalServiceKit/TSYapDatabaseObject.h>
@@ -423,17 +423,20 @@ static const NSInteger kProfileKeyLength = 16;
     OWSAssert(failureBlock);
 
     dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
-        // TODO: Do we need to use NSDataBase64EncodingOptions?
+        NSData *_Nullable profileNameEncrypted = [self encryptProfileString:localProfileName];
-        NSString *_Nullable localProfileNameBase64 = [[self encryptProfileString:localProfileName] base64EncodedString];
-        NSString *_Nullable avatarUrlBase64 = [[avatarUrl dataUsingEncoding:NSUTF8StringEncoding] base64EncodedString];
-        NSString *_Nullable avatarDigestBase64 = [avatarDigest base64EncodedString];
 
-        // TODO:
+        TSSetProfileRequest *request = [[TSSetProfileRequest alloc] initWithProfileName:profileNameEncrypted
-        if (YES) {
+                                                                              avatarUrl:avatarUrl
+                                                                           avatarDigest:avatarDigest];
+
+        [self.networkManager makeRequest:request
+            success:^(NSURLSessionDataTask *task, id responseObject) {
                 successBlock();
-            return;
             }
+            failure:^(NSURLSessionDataTask *task, NSError *error) {
+                DDLogError(@"%@ Failed to update profile with error: %@", self.tag, error);
                 failureBlock();
+            }];
     });
 }
 
@@ -669,10 +672,13 @@ static const NSInteger kProfileKeyLength = 16;
 - (void)updateProfileForRecipientId:(NSString *)recipientId
                profileNameEncrypted:(NSData *_Nullable)profileNameEncrypted
                       avatarUrlData:(NSData *_Nullable)avatarUrlData
-                       avatarDigest:(NSData *_Nullable)avatarDigest
+                       avatarDigest:(NSData *_Nullable)avatarDigestParam
 {
     OWSAssert(recipientId.length > 0);
 
+    // Ensure decryption, etc. off main thread.
+    dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
+
         UserProfile *userProfile = [self getOrBuildUserProfileForRecipientId:recipientId];
         if (!userProfile.profileKey) {
             return;
@@ -682,6 +688,7 @@ static const NSInteger kProfileKeyLength = 16;
             [self decryptProfileString:profileNameEncrypted profileKey:userProfile.profileKey];
         NSString *_Nullable avatarUrl
             = (avatarUrlData ? [[NSString alloc] initWithData:avatarUrlData encoding:NSUTF8StringEncoding] : nil);
+        NSData *_Nullable avatarDigest = avatarDigestParam;
 
         if (!avatarUrl || !avatarDigest) {
             // If either avatar url or digest is missing, skip both.
@@ -710,6 +717,7 @@ static const NSInteger kProfileKeyLength = 16;
 
             [self saveUserProfile:userProfile];
         });
+    });
 }
 
 - (BOOL)isNullableDataEqual:(NSData *_Nullable)left toData:(NSData *_Nullable)right

Signal/src/ViewControllers/ProfileViewController.m

@@ -218,7 +218,9 @@ NS_ASSUME_NONNULL_BEGIN
             [weakSelf.navigationController popViewControllerAnimated:YES];
         }
         failure:^{
-                                                        // TODO: Handle failure.
+            [OWSAlerts showAlertWithTitle:NSLocalizedString(@"ALERT_ERROR_TITLE", @"")
+                                  message:NSLocalizedString(@"PROFILE_VIEW_ERROR_UPDATE_FAILED",
+                                              @"Error message shown when a profile update fails.")];
         }];
 }
 

Signal/translations/en.lproj/Localizable.strings

@@ -1069,6 +1069,9 @@
 /* Label for action that clear's the user's profile avatar */
 "PROFILE_VIEW_CLEAR_AVATAR" = "Clear Avatar";
 
+/* Error message shown when a profile update fails. */
+"PROFILE_VIEW_ERROR_UPDATE_FAILED" = "Profile update failed.";
+
 /* Default text for the profile name field of the profile view. */
 "PROFILE_VIEW_NAME_DEFAULT_TEXT" = "Enter your name.";
 

SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSentMessageTranscript.m

@@ -14,7 +14,7 @@ NS_ASSUME_NONNULL_BEGIN
  * Normally this is private, but we need to embed this
  * data structure within our own.
  */
-- (OWSSignalServiceProtosDataMessage *)buildDataMessage:(NSString *)recipientId;
+- (OWSSignalServiceProtosDataMessage *)buildDataMessage:(NSString *_Nullable)recipientId;
 
 @end
 

SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m

@@ -455,10 +455,9 @@ NSString *const kTSOutgoingMessageSentRecipientAll = @"kTSOutgoingMessageSentRec
     return builder;
 }
 
-- (OWSSignalServiceProtosDataMessage *)buildDataMessage:(NSString *)recipientId
+- (OWSSignalServiceProtosDataMessage *)buildDataMessage:(NSString *_Nullable)recipientId
 {
     OWSAssert(self.thread);
-    OWSAssert(recipientId.length > 0);
 
     OWSSignalServiceProtosDataMessageBuilder *builder = [self dataMessageBuilder];
     [builder addLocalProfileKeyIfNecessary:self.thread recipientId:recipientId];

SignalServiceKit/src/Network/API/Requests/TSSetProfileRequest.h

@@ -0,0 +1,19 @@
+//
+//  Copyright (c) 2017 Open Whisper Systems. All rights reserved.
+//
+
+#import "TSRequest.h"
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface TSSetProfileRequest : TSRequest
+
+- (nullable instancetype)initWithProfileName:(NSData *_Nullable)profileNameEncrypted
+                                   avatarUrl:(NSString *_Nullable)avatarUrl
+                                avatarDigest:(NSData *_Nullable)avatarDigest;
+
+- (instancetype)init NS_UNAVAILABLE;
+
+@end
+
+NS_ASSUME_NONNULL_END

SignalServiceKit/src/Network/API/Requests/TSSetProfileRequest.m

@@ -0,0 +1,37 @@
+//
+//  Copyright (c) 2017 Open Whisper Systems. All rights reserved.
+//
+
+#import "TSSetProfileRequest.h"
+#import "NSData+Base64.h"
+#import "TSConstants.h"
+
+NS_ASSUME_NONNULL_BEGIN
+
+@implementation TSSetProfileRequest
+
+- (nullable instancetype)initWithProfileName:(NSData *_Nullable)profileNameEncrypted
+                                   avatarUrl:(NSString *_Nullable)avatarUrl
+                                avatarDigest:(NSData *_Nullable)avatarDigest
+{
+
+    self = [super initWithURL:[NSURL URLWithString:textSecureSetProfileAPI]];
+
+    self.HTTPMethod = @"PUT";
+
+    if (profileNameEncrypted.length > 0) {
+        self.parameters[@"name"] = [profileNameEncrypted base64EncodedString];
+    }
+    if (avatarUrl.length > 0) {
+        self.parameters[@"avatar"] = [[avatarUrl dataUsingEncoding:NSUTF8StringEncoding] base64EncodedString];
+    }
+    if (avatarDigest.length > 0) {
+        self.parameters[@"avatarDigest"] = [avatarDigest base64EncodedString];
+    }
+
+    return self;
+}
+
+@end
+
+NS_ASSUME_NONNULL_END

SignalServiceKit/src/Protocols/ProtoBuf+OWS.h

@@ -16,7 +16,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 @interface OWSSignalServiceProtosDataMessageBuilder (OWS)
 
-- (void)addLocalProfileKeyIfNecessary:(TSThread *)thread recipientId:(NSString *)recipientId;
+- (void)addLocalProfileKeyIfNecessary:(TSThread *)thread recipientId:(NSString *_Nullable)recipientId;
 
 @end
 

SignalServiceKit/src/Protocols/ProtoBuf+OWS.m

@@ -12,11 +12,9 @@ NS_ASSUME_NONNULL_BEGIN
 
 @implementation PBGeneratedMessageBuilder (OWS)
 
-- (BOOL)shouldMessageHaveLocalProfileKey:(TSThread *)thread recipientId:(NSString *)recipientId
+- (BOOL)shouldMessageHaveLocalProfileKey:(TSThread *)thread recipientId:(NSString *_Nullable)recipientId
-//                            recipient:(SignalRecipient *)recipient
 {
     OWSAssert(thread);
-    OWSAssert(recipientId.length > 0);
 
     id<ProfileManagerProtocol> profileManager = [TextSecureKitEnv sharedEnv].profileManager;
 
@@ -25,7 +23,7 @@ NS_ASSUME_NONNULL_BEGIN
     //
     // For Group threads, we want to include the profile key IFF the
     // recipient OR the group is in the whitelist.
-    if ([profileManager isUserInProfileWhitelist:recipientId]) {
+    if (recipientId.length > 0 && [profileManager isUserInProfileWhitelist:recipientId]) {
         return YES;
     } else if ([profileManager isThreadInProfileWhitelist:thread]) {
         return YES;
@@ -46,10 +44,9 @@ NS_ASSUME_NONNULL_BEGIN
 
 @implementation OWSSignalServiceProtosDataMessageBuilder (OWS)
 
-- (void)addLocalProfileKeyIfNecessary:(TSThread *)thread recipientId:(NSString *)recipientId
+- (void)addLocalProfileKeyIfNecessary:(TSThread *)thread recipientId:(NSString *_Nullable)recipientId
 {
     OWSAssert(thread);
-    OWSAssert(recipientId.length > 0);
 
     if ([self shouldMessageHaveLocalProfileKey:thread recipientId:recipientId]) {
         [self setProfileKey:self.localProfileKey];

SignalServiceKit/src/TSConstants.h

@@ -41,6 +41,7 @@ typedef enum { kSMSVerification, kPhoneNumberVerification } VerificationTranspor
 #define textSecureDeviceProvisioningAPIFormat @"v1/provisioning/%@"
 #define textSecureDevicesAPIFormat @"v1/devices/%@"
 #define textSecureProfileAPIFormat @"v1/profile/%@"
+#define textSecureSetProfileAPI @"v1/profile"
 
 #pragma mark Push RegistrationSpecific Constants
 typedef NS_ENUM(NSInteger, TSPushRegistrationError) {