keejef
/
session-ios
mirror of https://github.com/oxen-io/session-ios
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

PeerConnectionClient thread safety.

Browse Source
pull/1/head
Matthew Chen 7 years ago
parent e63a7f8fb0
commit 88c2ff26e7
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File

26
Signal/src/call/PeerConnectionClient.swift
Unescape Escape View File

@ -178,7 +178,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
ensureTeardown(#function) ensureTeardown(#function)
} }
guard let peerConnection = peerConnection else { guard let peerConnection = peerConnection else {
owsFail("\(logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
@ -209,7 +209,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
return return
} }
guard let peerConnection = peerConnection else { guard let peerConnection = peerConnection else {
owsFail("\(logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
@ -248,7 +248,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
strongSelf.ensureTeardown(#function) strongSelf.ensureTeardown(#function)
} }
guard let localVideoSource = strongSelf.localVideoSource else { guard let localVideoSource = strongSelf.localVideoSource else {
owsFail("\(strongSelf.logTag) in \(#function) localVideoSource was unexpectedly nil") Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
@ -289,12 +289,11 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
return return
} }
guard let localVideoTrack = strongSelf.localVideoTrack else { guard let localVideoTrack = strongSelf.localVideoTrack else {
let action = enabled ? "enable" : "disable" Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
Logger.error("\(strongSelf.logTag)) trying to \(action) videoTrack which doesn't exist")
return return
} }
guard let videoCaptureSession = strongSelf.videoCaptureSession else { guard let videoCaptureSession = strongSelf.videoCaptureSession else {
Logger.debug("\(strongSelf.logTag) videoCaptureSession was unexpectedly nil") Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
@ -324,7 +323,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
assert(self.audioSender == nil, "\(#function) should only be called once.") assert(self.audioSender == nil, "\(#function) should only be called once.")
guard let peerConnection = peerConnection else { guard let peerConnection = peerConnection else {
owsFail("\(logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
@ -362,8 +361,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
return return
} }
guard let audioTrack = strongSelf.audioTrack else { guard let audioTrack = strongSelf.audioTrack else {
let action = enabled ? "enable" : "disable" Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
Logger.error("\(strongSelf.logTag) trying to \(action) audioTrack which doesn't exist.")
return return
} }
@ -457,7 +455,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
strongSelf.assertOnSignalingQueue() strongSelf.assertOnSignalingQueue()
guard let peerConnection = peerConnection else { guard let peerConnection = peerConnection else {
owsFail("\(strongSelf.logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
@ -860,7 +858,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
} }
guard let peerConnection = strongSelf.peerConnection else { guard let peerConnection = strongSelf.peerConnection else {
owsFail("\(strongSelf.logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
guard peerConnection == peerConnectionParam else { guard peerConnection == peerConnectionParam else {
@ -940,7 +938,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
} }
guard let peerConnection = strongSelf.peerConnection else { guard let peerConnection = strongSelf.peerConnection else {
owsFail("\(strongSelf.logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
guard peerConnection == peerConnectionParam else { guard peerConnection == peerConnectionParam else {
@ -996,7 +994,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
} }
guard let peerConnection = strongSelf.peerConnection else { guard let peerConnection = strongSelf.peerConnection else {
owsFail("\(strongSelf.logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
guard peerConnection == peerConnectionParam else { guard peerConnection == peerConnectionParam else {
@ -1043,7 +1041,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
} }
guard let peerConnection = strongSelf.peerConnection else { guard let peerConnection = strongSelf.peerConnection else {
owsFail("\(strongSelf.logTag) in \(#function) peerConnection was unexpectedly nil") Logger.debug("\(strongSelf.logTag) \(#function) Ignoring obsolete event in terminated client")
return return
} }
guard peerConnection == peerConnectionParam else { guard peerConnection == peerConnectionParam else {

Write Preview
Loading…
Cancel
Save