Respond to CR.

Signal/src/util/AppUpdateNag.m

@@ -58,6 +58,10 @@ NSString *const OWSPrimaryStorageAppUpgradeNagDate = @"TSStorageManagerAppUpgrad
 
 - (void)showAppUpgradeNagIfNecessary
 {
+    if (CurrentAppContext().isRunningTests) {
+        return;
+    }
+
     // Only show nag if we are "at rest" in the home view or registration view without any
     // alerts or dialogs showing.
     UIViewController *frontmostViewController =

Signal/test/Models/AccountManagerTest.swift

@@ -18,7 +18,13 @@ enum PushNotificationRequestResult: String {
 }
 
 class FailingTSAccountManager: TSAccountManager {
-    let phoneNumberAwaitingVerification = "+13235555555"
+    override public init(networkManager: TSNetworkManager, primaryStorage: OWSPrimaryStorage) {
+        SwiftAssertIsOnMainThread(#function)
+
+        super.init(networkManager: networkManager, primaryStorage: primaryStorage)
+
+        self.phoneNumberAwaitingVerification = "+13235555555"
+    }
 
     override func verifyAccount(withCode: String,
                                 pin: String?,

SignalServiceKit/src/Account/TSAccountManager.h

@@ -17,6 +17,11 @@ extern NSString *const kNSNotificationName_LocalNumberDidChange;
 
 @interface TSAccountManager : NSObject
 
+// This property is exposed for testing purposes only.
+#ifdef DEBUG
+@property (nonatomic, nullable) NSString *phoneNumberAwaitingVerification;
+#endif
+
 #pragma mark - Initializers
 
 - (instancetype)init NS_UNAVAILABLE;