Clean

Signal/src/Loki/View Controllers/HomeVC.swift

@@ -216,16 +216,12 @@ final class HomeVC : BaseVC, UITableViewDataSource, UITableViewDelegate, UIScrol
         isObservingDatabase = isViewVisible && CurrentAppContext().isAppForegroundAndActive()
     }
     
-    private func updateYDBThreadMapping() {
+    private func reload() {
+        AssertIsOnMainThread()
         uiDatabaseConnection.beginLongLivedReadTransaction()
         uiDatabaseConnection.read { transaction in
             self.threads.update(with: transaction)
         }
-    }
-    
-    private func reload() {
-        AssertIsOnMainThread()
-        updateYDBThreadMapping()
         threadViewModelCache.removeAll()
         tableView.reloadData()
         emptyStateView.isHidden = (threadCount != 0)
@@ -243,17 +239,13 @@ final class HomeVC : BaseVC, UITableViewDataSource, UITableViewDelegate, UIScrol
             }
             return
         }
-        // Guard for changes made in Notification Service Extension
+        // If changes were made in a different process (e.g. the Notification Service Extension) the thread mapping can be out of date
-        // Crashes may happen if there is some modification in NSE
+        // at this point, causing the app to crash. The code below prevents that by force syncing the database before proceeding.
-        // The YapDBModificationNotification cannot cross process
+        if notifications.count > 0 {
-        // So the thread mapping won't update itself if DB modification happened in other process like NSE
+            if let firstChangeSet = notifications[0].userInfo {
-        // With these code we can sync the mapping before asking for changes from YapDB
+                let firstSnapshot = firstChangeSet[YapDatabaseSnapshotKey] as! UInt64
-        if (notifications.count > 0) {
+                if threads.snapshotOfLastUpdate != firstSnapshot - 1 {
-            if let firstChangeset = notifications[0].userInfo {
+                    return reload()
-                let firstSnapshot = firstChangeset[YapDatabaseSnapshotKey] as! UInt64
-                if (self.threads.snapshotOfLastUpdate != firstSnapshot - 1) {
-                    reload()
-                    return
                 }
             }
         }
@@ -283,7 +275,6 @@ final class HomeVC : BaseVC, UITableViewDataSource, UITableViewDelegate, UIScrol
     
     @objc private func handleApplicationDidBecomeActiveNotification(_ notification: Notification) {
         updateIsObservingDatabase()
-        updateYDBThreadMapping()
     }
     
     @objc private func handleApplicationWillResignActiveNotification(_ notification: Notification) {

Signal/src/util/MainAppContext.m

@@ -157,7 +157,6 @@ NSString *const ReportedApplicationStateDidChangeNotification = @"ReportedApplic
 
 - (BOOL)isMainAppAndActive
 {
-    if (![NSThread isMainThread]) { return NO; }
     return [UIApplication sharedApplication].applicationState == UIApplicationStateActive;
 }