Commit Graph

879 Commits (220dfef1ab3eb4f5ca06ffdc964827e05e8b4e8e)

Author SHA1 Message Date
Matthew Chen 284cc8c265 Apply attachment type assets. 7 years ago
Matthew Chen 146db1984b Apply attachment type assets. 7 years ago
Michael Kirk 64ff4cd660 tap-to-retry failed thumbnail downloads
// FREEBIE
7 years ago
Matthew Chen f6d5b9197c Respond to CR. 7 years ago
Matthew Chen bb9c1fb23d Apply design changes from Myles. 7 years ago
Matthew Chen 6a69070ce9 Apply design changes from Myles. 7 years ago
Matthew Chen 6831412e44 Respond to CR. 7 years ago
Matthew Chen a5c7bdb987 Don't animate changes to shape layer properties. 7 years ago
Matthew Chen 59a3d736bf Respond to CR. 7 years ago
Matthew Chen d7ae35f72c Streamline usage of quoted message view. 7 years ago
Matthew Chen 195d357370 Streamline usage of quoted message view. 7 years ago
Matthew Chen 9c93099515 Fix incomplete asserts. 7 years ago
Matthew Chen 6caa5b87b6 Add more asserts around thread in SAE. 7 years ago
Matthew Chen 644e78f19d Respond to CR. 7 years ago
Michael Kirk e554884ab3 Use profile name in quoted messages, fix "multi account" label
// FREEBIE
7 years ago
Michael Kirk 40879ca3e3 Distinguish between quoting yourself and someone else quoting you
// FREEBIE
7 years ago
Michael Kirk 5774e5769d truncate tail for both preview and message bubble
// FREEBIE
7 years ago
Matthew Chen 576f5dee88 Add white background to images in quoted reply view. 7 years ago
Matthew Chen fc2704cf88 Label quoted replies to yourself as such. 7 years ago
Matthew Chen 759b2a332f Respond to CR. 7 years ago
Matthew Chen ea82419a40 Fix long press on quoted reply. 7 years ago
Matthew Chen 031a1d7325 Fix quoted message overflow. 7 years ago
Matthew Chen ae91b03c71 Add white background to images in conversation view. 7 years ago
Michael Kirk 5320536736 remove WIP comments
// FREEBIE
7 years ago
Michael Kirk 7abd51838f Move bubble actions to new bubble delegate
// FREEBIE
7 years ago
Matthew Chen f6698501df Revert "Label quoted replies to yourself as such."
This reverts commit 24d7492f61.
7 years ago
Matthew Chen 24d7492f61 Label quoted replies to yourself as such. 7 years ago
Matthew Chen abba24988c Rework how dates are formatted in home view. 7 years ago
Michael Kirk 6b6f4f9336 Limit caption length
// FREEBIE
7 years ago
Matthew Chen 9769d482da Respond to CR. 7 years ago
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 7 years ago
Matthew Chen f2b416d800 Respond to CR. 7 years ago
Matthew Chen 8b060a187c Tap on quoted replies. 7 years ago
Matthew Chen 65015e686f Tap on quoted replies. 7 years ago
Matthew Chen e8ad6bad87 Respond to CR. 7 years ago
Matthew Chen ebb89ed1fd Tweak message layout. 7 years ago
Michael Kirk 520dad25bb WIP making OWSQuotedMessageView work with preview
// FREEBIE
7 years ago
Michael Kirk 5287ab8f8c Try 2: no more stack view
// FREEBIE
7 years ago
Matthew Chen 8fe289feec Tweak design of quoted replies. 7 years ago
Matthew Chen 3799dce822 Respond to CR. 7 years ago
Matthew Chen c106a67a52 Use dynamic type everywhere in conversation view. 7 years ago
Matthew Chen ade2ee7216 Use dynamic type everywhere in conversation view. 7 years ago
Michael Kirk 941b7ec1bc clarify method signature
// FREEBIE
7 years ago
Michael Kirk c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
7 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
7 years ago
Michael Kirk a9459757f0 Lingering var renames QuotedReplyDraft -> QuotedReplyModel
// FREEBIE
7 years ago
Michael Kirk fa2e1ba89b Fetch thumbnail when not available locally
// FREEBIE
7 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
7 years ago
Michael Kirk 55c6d99d98 populate draft toolbar
// FREEBIE
7 years ago
Michael Kirk 253435b27f extract QuotedReplyDraft model 7 years ago
Michael Kirk 0b8b3b4f16 WIP: towards avatar attachment streams
// FREEBIE
7 years ago
Michael Kirk 53af41fcc6 Reusable UploadOperation based on extracted OWSOperation
// FREEBIE
7 years ago
Matthew Chen 0dfdb8ce88 Elaborate quoted reply variations to include replies with attachments. 7 years ago
Matthew Chen de2dc49126 Elaborate quoted reply variations to include replies with attachments. 7 years ago
Matthew Chen 3ee37bd3f0 Respond to CR. 7 years ago
Matthew Chen 2f2d1f81a8 Clean up ahead of PR. 7 years ago
Matthew Chen 6830d4e8cb Apply message bubble view to message details view. 7 years ago
Matthew Chen d99a2be005 Apply message bubble view to message details view. 7 years ago
Matthew Chen 316b55bf9d Respond to CR. 7 years ago
Matthew Chen 7067085cdd Extract message bubble view. 7 years ago
Matthew Chen d05b73af28 Extract message bubble view. 7 years ago
Matthew Chen d1060a2a85 Extract message bubble view. 7 years ago
Matthew Chen 7f0fa1228e Extract message bubble view. 7 years ago
Matthew Chen c5d8a7cb38 Clean up ahead of PR. 7 years ago
Matthew Chen f6aa3f89b7 Clean up ahead of PR. 7 years ago
Matthew Chen ca4757b8d1 Clean up ahead of PR. 7 years ago
Matthew Chen 71c5c3a4b7 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 8a843f70e3 Refine the attachments in the quoted reply view. 7 years ago
Matthew Chen 822aa64b14 Respond to CR. 7 years ago
Matthew Chen cac85508cc Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 7e921b7935 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 08ba3852cd Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 5235f6eee9 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen d6f3df82ae Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen c70f911f6f Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 6171505657 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 10b4ade55a Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 3343b4ec58 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 9085609087 Fix interaction initializers and tests. 7 years ago
Michael Kirk 51eee90bb7 Remove unnecessary changes
// FREEBIE
7 years ago
Michael Kirk bf401bad90 Send quoted messages
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Michael Kirk d99054d895 Reply menu item
MVP

- [x] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Michael Kirk 6874a9e28e Convert to swift
// FREEBIE
7 years ago
Michael Kirk cfbbeca7ac WIP: QuotedMessagePreviewView
MVP

- [] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Matthew Chen 00a81355d6 Respond to CR. 7 years ago
Matthew Chen 324afb1152 Modify cells to show quoted messages. 7 years ago
Matthew Chen 5824cbd2a8 Modify cells to show quoted messages. 7 years ago
Matthew Chen 988b6ffae7 Modify cells to show quoted messages. 7 years ago
Matthew Chen f6f98369a6 Modify cells to show quoted messages. 7 years ago
Matthew Chen 22dc904283 Modify cells to show quoted messages. 7 years ago
Matthew Chen 2278cdd589 Modify cells to show quoted messages. 7 years ago
Matthew Chen 7cf169012c Elaborate conversation view items around quoted replies. 7 years ago
Matthew Chen c36297a9ad Elaborate 'quoted reply' variations in the Debug UI. 7 years ago
Matthew Chen d5218cf4d9 Simplify bubble edge. 7 years ago
Michael Kirk 00e5e1b0d6 Fixup some tests
// FREEBIE
7 years ago
Michael Kirk f441c6211d Format
// FREEBIE
7 years ago
Michael Kirk 6f1608f44b Conventional naming for out custom PureLayout methods.
This moves methods more in line with PureLayout conventions.

- Methods always specify if they pin to an edge vs margin

- `margin` is a reserved word which should only refer to layout margins.
  i.e. do not use it to refer to "inset" and "offset".

// FREEBIE
7 years ago
Matthew Chen 4240b517d0 Respond to CR. 7 years ago
Matthew Chen fb1f3b5572 Rework quoted reply debug UI. 7 years ago
Matthew Chen 4915c127cb Rework quoted reply debug UI. 7 years ago
Matthew Chen 8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
7 years ago
Matthew Chen 1bea832faa Fix assert in bubble views. 7 years ago
Matthew Chen f98c45603c Respond to CR. 7 years ago
Matthew Chen 12bcf887c1 Bubble collapse. 7 years ago
Matthew Chen 4f9085a761 Bubble collapse. 7 years ago
Matthew Chen 3ca2c08b06 Bubble collapse. 7 years ago
Matthew Chen 578f40d791 Bubble collapse. 7 years ago
Matthew Chen c8012d3891 Bubble collapse. 7 years ago
Matthew Chen 3d07dc7c5b Bubble collapse. 7 years ago
Matthew Chen 8d74c68f9d Bubble collapse. 7 years ago
Matthew Chen 8a74e10208 Bubble collapse. 7 years ago
Matthew Chen e0e8eafb5d Bubble collapse. 7 years ago
Matthew Chen e1e6606783 Bubble collapse. 7 years ago
Matthew Chen cb00b22870 Bubble collapse. 7 years ago
Matthew Chen 6525ccdb05 Bubble collapse. 7 years ago
Matthew Chen 75177ef00f Bubble collapse. 7 years ago
Matthew Chen 3a5ba15d21 Elaborate debug UI for messages. 7 years ago
Matthew Chen c2e31540d7 Elaborate debug UI for messages. 7 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
7 years ago
Michael Kirk 6c877403cf Fix delete from message details
// FREEBIE
7 years ago
Michael Kirk 00b5316976 Don't show the "All Media" button when viewing the slider from the
gallery via settings.

In this context it makes more sense for the user to hit the "dismiss"
button to get "back" to "All Media"

// FREEBIE
7 years ago
Michael Kirk ae8dbeb8dd Access Media Gallery from conversation settings
// FREEBIE
7 years ago
Michael Kirk dfd628250d Gallery performance
- [x] share uiDatabaseConnection to share cache
- [x] increase cache size
- [x] load less initially
- [x] lazy loading
  - [x] slider view
  - [x] tile view

// FREEBIE
7 years ago
Michael Kirk 985af76d0b WIP: All Media view
TODO

- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style

NICE TO HAVE

- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"

DONE

- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells

// FREEBIE

WIP WIP extract datasouce to GalleryViewController

- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation

// FREEBIE
7 years ago
Michael Kirk 4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
7 years ago
Michael Kirk 88e1386720 Move frame to presentation logic, out of init
This no longer made sense now that we're using this in a
PageViewController we won't always be zooming from a particular frame.

TODO:

- why is background image all wonky?
- why aren't views created by the time it's presented? Is that a
regression? (how is self.view a MenuView if loadView hasn't been called)

// FREEBIE
7 years ago
Matthew Chen b296cfb893 Sketch out incremental backup manager and settings view. 7 years ago
Michael Kirk a1de99f1f1 Merge tag '2.21.0.9' 7 years ago
Matthew Chen d6f4db1523 Rename TSStorageManager to OWSPrimaryStorage. 7 years ago
Michael Kirk d7fcac8a5a In-App notifications don't pause background audio
// FREEBIE
7 years ago
Michael Kirk 07ee3ea843 Merge tag '2.21.0.5' 7 years ago
Michael Kirk 6077367e66 Notification sounds should respect silent switch
// FREEBIE
7 years ago
Matthew Chen baf6fcc535 Add 2FA registration view. 7 years ago
Matthew Chen e12a1e984a Work on two-factor auth settings UI. 7 years ago
Matthew Chen 38ff82ab97 Rebrand OWSAudioPlayer. 7 years ago
Matthew Chen 99aedca45f Strip out special casing for pre-iOS 9 users. 7 years ago
Matthew Chen 81629a87df Fix build break. 7 years ago
Matthew Chen 152c570900 Respond to CR. 7 years ago
Matthew Chen 03670b4868 Rename the view horizon. 7 years ago
Matthew Chen fabbe46114 Clean up ahead of PR. 7 years ago
Matthew Chen 4e1e232825 Flush writes from other processes. 7 years ago
Matthew Chen 1ff4f85247 Improve handling of db modifications while conversation view is not observing. 7 years ago
Matthew Chen 2ac7716771 Improve handling of db modifications while conversation view is not observing. 7 years ago
Michael Kirk 5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
7 years ago
Michael Kirk d7f8c3e9d3 Ensure inputAccessory doesn't obscure the SN alert
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.

// FREEBIE
7 years ago
Michael Kirk abb51b565a Don't de-activate audio sesion when other audio activities are happening
// FREEBIE
7 years ago
Matthew Chen ceaf028445 Always scroll to bottom after sending attachments. 7 years ago
Matthew Chen e3776015bb Respond to CR. 7 years ago
Matthew Chen 246a56e925 Respond to CR. 7 years ago
Matthew Chen 33686594e9 Tweak debug logging. 7 years ago
Matthew Chen ba42ac73d8 Revisit TODOs in the SAE work. 7 years ago
Matthew Chen bd0f601792 Respond to CR. 7 years ago
Matthew Chen 43765ef3b5 Respond to CR. 7 years ago
Matthew Chen bbd689bfd0 Add protocol context to protocol kit. 7 years ago
Matthew Chen d3e16583eb Add protocol context to protocol kit. 7 years ago
Michael Kirk c646f76335 Garther audio concerns, clean up session when done
- sync speakerphone state manipulated from system call screen
  - Revert audio session after call failure, ensures media plays out of
    speaker after placing a failing call.
  - Replace notification with delegate pattern since we're already using
    delegate pattern here.
- Fixes voiceover accessibility after voice memo
- Avoid audio blip after pressing hangup
- Rename CallAudioSession -> OWSAudioSession
  Going to start using it for other non-call things since we want to
  gather all our audio session concerns.
- Resume background audio when done playing video
  - Extract OWSVideoPlayer which ensures audio is in proper state before
    playback
  - Move recording session logic to shared OWSAudioSession
  - Deactivate audio session when complete

// FREEBIE
7 years ago
Michael Kirk 7734958eec Make "swipe for info" RTL compatible
// FREEBIE
7 years ago
Michael Kirk 54f7c298b7 Only initiate "show details" pan gesture when swiping back
// FREEBIE
7 years ago
Michael Kirk e39ca59eeb Merge tag '2.19.5.0' 7 years ago
Matthew Chen fa76e524c4 Respond to CR. 7 years ago
Matthew Chen 9c84bdb105 Add support for images as documents. 7 years ago
Matthew Chen 3609275c20 Handle malformed row updates. 7 years ago
Matthew Chen 069587b150 Add message approval view. 7 years ago
Matthew Chen 992e926142 Unpack oversize text messages if possible. 7 years ago
Matthew Chen b9bd21e73f Improve presentation of text attachments in attachment approval view. 7 years ago
Michael Kirk 05035e40a6 Fixup tests
// FREEBIE
7 years ago
Michael Kirk 6491bb8956 Fix timer offset
// FREEBIE
7 years ago
Michael Kirk baa312f449 Timer button with duration label
// FREEBIE
7 years ago
Michael Kirk f41dfa509c Re-aquire first responder when necessary.
// FREEBIE
7 years ago
Michael Kirk 3ca5ec2726 Ensure media-library permissions when accessing media library
// FREEBIE
7 years ago
Michael Kirk 5dde17d939 Show approval/caption view in app.
ApprovalView/Captioning is shown for:
- Images/Videos from Library
- Images/Video from Camera
- Document Picker
- GIFs

Voice notes are intentionally not captionable.

Also, in main app, hide status bar when ApprovalView is presented

// FREEBIE
7 years ago
Michael Kirk 58558b36de Add clarifying comment.
// FREEBIE
7 years ago
Michael Kirk 0c6a42003f clang-format after RI
// FREEBIE
7 years ago
Michael Kirk a423fe8a0e WIP Merge tag '2.19.4.4'
- restore video playback in fullscreen

This was a large merge, so I'm opting to make some changes in separate
commits.
7 years ago
Matthew Chen 17907dca10 Clean up ahead of PR. 7 years ago
Matthew Chen 15b8e58324 Retain changes from session database branch. 7 years ago
Michael Kirk 63c23b77d0 Cleanup presentation view, feels less blurry
// FREEBIE
7 years ago
Michael Kirk 8851413b35 CR: cleanup, remove debug animation time, move constant
// FREEBIE
7 years ago
Michael Kirk 74e03aad01 Fix intermittent content offset problem
Using the CollectionView's frame to determine if we're at the bottom
doesn't make sense unless the collection view is correctly layed out.

// FREEBIE
7 years ago
Matthew Chen 16f7317579 Complete backup restore/import. 7 years ago
Matthew Chen 272a90d269 Add import back up UI. Begin work on import backup logic. 7 years ago
Matthew Chen e77c3e6717 Retain changes from session database branch. 7 years ago
Michael Kirk 74019b2ae4 Fix keyboard animation glitch after sending
// FREEBIE
7 years ago
Michael Kirk 1ec409ad2b CR: re-enable default keyboard toggle
// FREEBIE
7 years ago
Michael Kirk 8d2934d86e CR: remove unnecessary code, comments
// FREEBIE
7 years ago
Michael Kirk 412fe2735e Rename FullImageViewController -> MediaDetailViewController
// FREEBIE
7 years ago
Michael Kirk 918e3f7dfe Videos play in full-screen media view controller, use modern movie
player.

// FREEBIE
7 years ago
Michael Kirk 81268012e5 Better keyboard management.
- fixes problems on iOS11.2 where emoji keyboard sometimes obscures text
  input.
- better animation for interactive pan gesture when viewing message
  details
- more intuitive swipe-to-dismiss keyboard in conversation view
- converge on one mnethod for dismissing keyboard in conversation view

- [ ] Pop keyboard, then hit attachment, dismisses keyboard, which is
      fine, but the content should immediately scroll down with the
      keyboard, instead it stays up, and scrolls down only once the
      attachment action sheet has been dismissed.

// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf b87079d4b4 Sharing attachment shows progress / retry dialog
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 513e33b0fd Cleanup before code review
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf cf091758a5 Fix oversized text messages
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 82aeee301d can delete text messages again
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf f5b9ae97ef fix insets for incoming vs outgoin
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf eeaea5fa01 better match for corner radius
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 0ea3a36559 make sure captioned attachment doesn't grow too large
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 0e9c9a9bb3 Separate gestures for text/vs media
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 92477c78b7 cleanup before PR 7 years ago
Michael Kirk bce18637f0 render attachments with captions
// FREEBIE
7 years ago
Michael Kirk 3176cb5a62 text sizing correctly 7 years ago
Michael Kirk f8866c4e0b Fix some constraints, get other attachment types looking good
TODO
- [ ] message bubble sizes are not correct. Not always wide enough to
      fit their content.

// FREEBIE
7 years ago
Michael Kirk 76ca52f33c caption bubble properly sized, but all attachments make space now 7 years ago
Michael Kirk 3eb3c268a9 Towards a caption in message
TODO

- [ ] adjust height properly
- [ ] all media types
- [ ] include caption in message details
- [ ] gestures working on both independently
- [ ] perf benchmark

// FREEBIE
7 years ago
Michael Kirk a5c5dd3f96 WIP, extract subclass 7 years ago
Matthew Chen 6b0e3508a5 Respond to CR. 7 years ago
Matthew Chen 9258b0883e Clean up TSStorageManager usage. 7 years ago
Matthew Chen 9a990b58e8 Respond to CR. 7 years ago
Matthew Chen 3643414da1 Respond to CR. 7 years ago
Matthew Chen e45d63e862 Clean up ahead of PR. 7 years ago
Matthew Chen 0c9d9ba679 Fix issues around cross process db changes. 7 years ago
Michael Kirk 8996741277 DocumentPicker converts to mp4 when necessary
// FREEBIE
7 years ago
Michael Kirk 031e40d090 Use SignalAttachment logic in conversation view too
// FREEBIE
7 years ago
Matthew Chen 74efcb9041 Rework thread safety in profile manager. 7 years ago
Matthew Chen 80ae5e0fcf Respond to CR. 7 years ago
Matthew Chen 11b4848530 Respond to CR. 7 years ago
Matthew Chen 84061cca9f Change image resizing/quality behavior, preferring smaller images in the common case. 7 years ago
Matthew Chen 125aabb0a3 Change image resizing/quality behavior, preferring smaller images in the common case. 7 years ago
Michael Kirk d9cca77e23 update header references
// FREEBIE
8 years ago
Matthew Chen b4e8df79da Migrate environment to SignalMessaging. 8 years ago
Matthew Chen 6d87df88aa Migrate environment to SignalMessaging. 8 years ago
Matthew Chen bf21d0c0ed Enable logging in SAE; rework log file management to include multiple log directories. 8 years ago
Matthew Chen 64762eb427 Observe YapDatabaseModifiedExternallyNotification. 8 years ago
Michael Kirk 9ac3ce3758 Memoize bubble factory
Shaves 5% off of initial conversation load.

// FREEBIE
8 years ago
Michael Kirk fd829ba575 Merge branch 'hotfix/2.19.1' 8 years ago
Michael Kirk a11d83187b WIP: Framework-friendly - compiles but crashes on launch
// FREEBIE
8 years ago
Michael Kirk 9d1e3dc223 We need to change file extensions when converting data
// FREEBIE
8 years ago
Michael Kirk 1a99b34913 Fix iOS8 crash on type
// FREEBIE
8 years ago
Michael Kirk a542471bbe center "Loading More Messages" label
// FREEBIE
8 years ago
Matthew Chen f9f0f1c27d Revert "Force conversation view cells to update layout immediately."
This reverts commit ef820a3719.
8 years ago
Matthew Chen 35bdc86ab5 Reload adjacent rows using original indices, not final indices. 8 years ago
Matthew Chen 71f5ef5940 Improve handling of unread indicator edge cases. 8 years ago
Matthew Chen 2ec1e7e925 Respond to CR. 8 years ago
Matthew Chen 2d241623b7 Improve handling of edge cases around unread indicator delimiting deleted message(s). 8 years ago
Matthew Chen 5ef9d53c91 Update conversation view UI to reflect unread state. 8 years ago
Matthew Chen ef820a3719 Force conversation view cells to update layout immediately.
// FREEBIE
8 years ago
Michael Kirk 370364c936 Scroll down button scrolls to unread
// FREEBIE
8 years ago
Matthew Chen b0c9add29c Update layout of "scroll down button" to reflect RTL. 8 years ago
Matthew Chen 92ef507810 Make swipe-for-details RTL-safe. 8 years ago
Matthew Chen aea2bf3e00 Fix scroll state insets in conversation view. 8 years ago
Matthew Chen 5cfa7e35f4 Respond to CR. 8 years ago
Michael Kirk 34811a635b Fixes: "connected call" showing as "unconnected outgoing" call.
Expire viewItem cache when resetting mappings

// FREEBIE
8 years ago
Matthew Chen b76d9a4e68 Remove redundant logTag methods. 8 years ago
Matthew Chen a4879f6bb5 Remove redundant logTag methods. 8 years ago
Matthew Chen 8eb4e682d9 Revert "Show menu controller from centroid of message cells."
This reverts commit 08bb1c909d.
8 years ago
Matthew Chen cebeea9189 Reduce extremes of Jumbomoji behavior. 8 years ago
Matthew Chen d8ae5841d6 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 45c7d80d97 Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 6d4a05bbea Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 658746093d Use finalIndex in row changes. 8 years ago
Michael Kirk 8ee030bea1 Don't dismiss keyboard when view appears
// FREEBIE
8 years ago
Matthew Chen 7b1a846f79 Dismiss keyboard when leaving conversation view. 8 years ago
Matthew Chen 572de11763 Apply dynamic type sizing to Jumbomoji. 8 years ago
Matthew Chen 937ac5830d Skip animations in conversation view. 8 years ago
Matthew Chen b67179b45d Skip animations in conversation view. 8 years ago
Matthew Chen 0ccddb696a Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
8 years ago
Matthew Chen 96274a60a9 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 7aae47b021 Reduce font size of "load more" indicator. 8 years ago
Matthew Chen dffd776ace Increase the max text message length. 8 years ago
Michael Kirk 228e350e2a message details shows failed bubble when appropriate
// FREEBIE
8 years ago
Matthew Chen 6b8f4c7dde Dismiss menu controller if message cell is hidden or recycled. 8 years ago
Matthew Chen 08bb1c909d Show menu controller from centroid of message cells. 8 years ago
Matthew Chen aad93d2d89 Fix broken assert in conversation view item. 8 years ago
Matthew Chen ddf4bf28cc Load attachments for conversation view items using long-lived db connection. 8 years ago
Matthew Chen df5aa5ef67 Update UI to reflect changes to disappearing messages configuration. 8 years ago
Michael Kirk 9675cbb1e1 Scroll only as far as necessary
// FREEBIE
8 years ago
Matthew Chen cc90f4cb80 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 86fdd6dea2 Fix edge cases in conversation view. 8 years ago
Matthew Chen 6413bc8e4c Evacuate the view item cache. 8 years ago
Matthew Chen 19ba564f80 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen c6160a5a1e Rework the "update with..." methods to avoid re-saving deleted models. 8 years ago
Michael Kirk 8c69e00a3f Adapt ConversationViewController to iPhoneX
// FREEBIE
8 years ago
Matthew Chen c3b6c9055e Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links. 8 years ago
Matthew Chen 3da1d8c63f Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links. 8 years ago
Matthew Chen c91dda43e0 Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links. 8 years ago
Matthew Chen c3087cf3df Don't dismiss keyboard when tapping in the conversation view. 8 years ago
Matthew Chen bf0f33e4b0 Temporarily alter animations in conversation view. 8 years ago
Matthew Chen af6a7c103c Add a comment. 8 years ago
Matthew Chen 42a70e0def Revert "Temporarily make logging around conversation view row updates more verbose."
This reverts commit 105b033761.
8 years ago
Matthew Chen f0a8e08df9 Temporarily alter animations in conversation view. 8 years ago
Matthew Chen 0abdbffe1f Improve handling of attachment edge cases. 8 years ago
Matthew Chen b5f7a4746f Temporarily alter animations in conversation view. 8 years ago
Matthew Chen 3814464595 Increase content insets of attachment button. 8 years ago
Matthew Chen 105b033761 Temporarily make logging around conversation view row updates more verbose. 8 years ago
Matthew Chen c72f39e64b Layout cell content when presenting the cell. 8 years ago
Matthew Chen 87b0692af0 Fixes for scrolling in conversation view. 8 years ago
Matthew Chen 5cc292fb6c Don't ask for camera permissions if app is not active.
// FREEBIE
8 years ago
Matthew Chen 5e61307ce3 Don't ask for microphone permissions if app is not active.
// FREEBIE
8 years ago
Matthew Chen 6e840ff956 Fix build warnings from XCode 9. 8 years ago
Matthew Chen 2d21e2ae2c Fix build warnings from XCode 9. 8 years ago
Michael Kirk 90dad75446 CR: remove unnecessary property
// FREEBIE
8 years ago
Michael Kirk 1f5603760b Fix contact offer
We never assign interaction, but we can get it via the viewItem.

// FREEBIE
8 years ago
Matthew Chen e3f7947da0 Emphasize borders of input toolbar.
// FREEBIE
8 years ago
Matthew Chen a5c4140a12 Reduce max text message bubble size.
// FREEBIE
8 years ago
Matthew Chen ea0b6065e3 Revert "Constrain the max text cell height to the height of the screen."
This reverts commit b9583a3c85a3b27f65b653a1d851c7c966fdc83d.

// FREEBIE
8 years ago
Matthew Chen 608cd2781f Constrain the max text cell height to the height of the screen.
// FREEBIE
8 years ago
Matthew Chen 7fd5b00d86 Fix text message links in conversation view.
// FREEBIE
8 years ago
Matthew Chen af5489952c Don't animate message sends.
// FREEBIE
8 years ago
Matthew Chen 40e04ffb92 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 5df4ac92b7 Don't animate message sends.
// FREEBIE
8 years ago
Matthew Chen 5d4316755f Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d52b19a69e Let users with external keyboards send messages using modifier-return (shift, command, option).
// FREEBIE
8 years ago
Matthew Chen 0c92850d38 Log voice memo durations.
// FREEBIE
8 years ago
Matthew Chen 89dbcb0fe8 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen f95e599c55 Don't overwrite draft after GIF send.
// FREEBIE
8 years ago
Matthew Chen a0ddb2a06d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9053d038ac Remove extra logging.
// FREEBIE
8 years ago
Matthew Chen 5ac2f16ebc Skip redundant relayout.
// FREEBIE
8 years ago
Matthew Chen 841a2333e3 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen eb3ca43256 Jumbomoji.
// FREEBIE
8 years ago
Matthew Chen bee70fa028 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 5e1c6c02a0 Add "failed message send" badges.
// FREEBIE
8 years ago
Matthew Chen 8cb3e5d35d Fix edge cases around oversize test messages.
// FREEBIE
8 years ago
Matthew Chen 9cc4521d07 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen bcf83a4c8e Rework handling of oversize text messages.
// FREEBIE
8 years ago
Michael Kirk 8f9311a6ac Show timer in navbar without reload
// FREEBIE
8 years ago
Michael Kirk 709010499f remove overzealous assert
// FREEBIE
8 years ago
Matthew Chen 7e585b72aa Fix tests broken by the JSQ rewrite.
// FREEBIE
8 years ago
Michael Kirk 2d7deff839 Make message bubbles a bit wider.
// FREEBIE
8 years ago
Michael Kirk cd291e19ff We conceivably want to to initiate calls more than once without leaving
the conversation view. e.g. from Contacts.app

// FREEBIE
8 years ago
Michael Kirk 4000760cf7 Fix "back button count" flash. Only call once.
This affects returning from message info or when leaving conversation
settings.

// FREEBIE
8 years ago
Matthew Chen df7d40ed4c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen a23b8b717b RTL fixes for JSQ rewrite.
// FREEBIE
8 years ago
Michael Kirk 43dd3abf6c clamp value per CR
// FREEBIE
8 years ago
Michael Kirk 59b125c3fb Add clarifying comment per CR
// FREEBIE
8 years ago
Michael Kirk d87f000051 Interactive/Cancelable slide left for details
// FREEBIE
8 years ago
Matthew Chen fb3bb852ca Tap image attachment preview to view full screen.
// FREEBIE
8 years ago
Matthew Chen 722fc4d7a7 Fix size of message previews.
// FREEBIE
8 years ago
Matthew Chen 0eafbd8fe4 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 188b733d57 Don't send with return key.
// FREEBIE
8 years ago
Matthew Chen 27af310235 Auto-dismiss keyboard if user scrolls away from bottom of the conversation.
// FREEBIE
8 years ago
Matthew Chen 3fa2f22beb Fixes for input toolbar.
// FREEBIE
8 years ago
Matthew Chen c9e385920a Fix spacing around date headers.
// FREEBIE
8 years ago
Matthew Chen 429f833913 Center the progress bar within the bubble mask.
// FREEBIE
8 years ago
Matthew Chen 658c3c5599 Only show attachment upload UI for not-yet-uploaded attachments.
// FREEBIE
8 years ago
Matthew Chen 067b16903c Fix attachment uploads.
// FREEBIE
8 years ago
Matthew Chen c1f35a0ea6 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 2fa3cf1bc6 Rework attachment approval UI.
// FREEBIE
8 years ago
Matthew Chen cbb0030b12 Rework attachment approval UI.
// FREEBIE
8 years ago
Matthew Chen d04f9111db Rework attachment approval UI.
// FREEBIE
8 years ago
Michael Kirk 1fee5d97e6 Merge branch 'release/2.18.0' 8 years ago
Matthew Chen a1d8c7765d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 54c56f1c4b Fix layout of generic and audio messages.
// FREEBIE
8 years ago
Matthew Chen a16197f193 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b1b0ddbf2e Fix layout glitches in JSQ rewrite.
// FREEBIE
8 years ago
Michael Kirk 21df2dc047 Never hide "failed to send" footer
// FREEBIE
8 years ago
Michael Kirk bd4b4f0041 Use proper color when messages fail to send.
// FREEBIE
8 years ago
Michael Kirk f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons."
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
8 years ago
Michael Kirk 66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 8 years ago
Michael Kirk 2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 8 years ago
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
8 years ago