Commit Graph

4960 Commits (f0f25aa41398868e5a85a173101fdb4635550cfe)

Author SHA1 Message Date
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Michael Kirk 8cd290ba2b fix section headers not appearing on iOS11/iPhoneX
// FREEBIE
7 years ago
Michael Kirk 92de745528 theme gallery section headers
// FREEBIE
7 years ago
Michael Kirk c1df969a22 remove overzealous assert
// FREEBIE
7 years ago
Matthew Chen 7020798e3f "Bump build to 2.29.0.13." 7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen 6e4414f477 "Bump build to 2.29.0.12." 7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen b4b4cd61d9 Improve message timestamp formatting. 7 years ago
Matthew Chen be7482eb60 Tap to copy sender timestamp to clipboard. 7 years ago
Matthew Chen f89fa8359b Revert "Add logging around 'SAE to same thread' crash."
This reverts commit eee2f7c8c6.
7 years ago
Matthew Chen e3378dec65 Revert "Add logging around 'share from SAE to same conversation' crash."
This reverts commit f62bf7d18e.
7 years ago
Matthew Chen 87d51aaa82 "Bump build to 2.29.0.11." 7 years ago
Matthew Chen f62bf7d18e Add logging around 'share from SAE to same conversation' crash. 7 years ago
Matthew Chen a712a20da0 "Bump build to 2.29.0.10." 7 years ago
Matthew Chen eee2f7c8c6 Add logging around 'SAE to same thread' crash. 7 years ago
Matthew Chen b347c40c66 Clean up ahead of PR. 7 years ago
Matthew Chen d9d73ba70c "Bump build to 2.29.0.9." 7 years ago
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 7 years ago
Matthew Chen 1e75b6518b "Bump build to 2.29.0.8." 7 years ago
Matthew Chen db2f5bf3b0 Add temporary logging around conversation view crashes. 7 years ago
Matthew Chen 30ce675236 "Bump build to 2.29.0.7." 7 years ago
Matthew Chen 420f5f88ff Add logging, error checking and recovery around corrupt message mappings. 7 years ago
Matthew Chen f261a47bd3 Hide home view search by default. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen 22dda476bb Fix QA issues in theme. 7 years ago
Matthew Chen 4e276b1095 Apply 'insets fix' correctly in message details view. 7 years ago
Matthew Chen 7766cb6d73 "Bump build to 2.29.0.6." 7 years ago
Matthew Chen 664e13fb46 Revert "Add temporary logging around conversation view crashes."
This reverts commit 26ad9814ee.
7 years ago
Matthew Chen 408689bbfc "Bump build to 2.29.0.5." 7 years ago
Matthew Chen 26ad9814ee Add temporary logging around conversation view crashes. 7 years ago
Matthew Chen 606b0debc7 "Bump build to 2.29.0.4." 7 years ago
Matthew Chen b3c19b7905 Improve logging of conversation view exceptions. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Michael Kirk e56abeac39 "Bump build to 2.29.0.3." 7 years ago
Michael Kirk b3cdf3dc01 sync translations 7 years ago
Michael Kirk a1e8bb865c Larger jumbomoji 7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk 7a0d74c17e Use dark blur for navbar
In the light theme, using the "light" blur allows the bar to seem invisible
when over white content. Similarly for the "dark" blur over black content.
7 years ago
Michael Kirk ebd2e6d5ac Tweak theme 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 5f468f4267 "Bump build to 2.29.0.2." 7 years ago
Matthew Chen 4096d2e0d8 Respond to CR. 7 years ago
Matthew Chen 2fecb270e6 Cache footer timestamp size. 7 years ago
Matthew Chen c91bc71ebd Cache sender name size. 7 years ago
Matthew Chen 3fc3425605 Theme search bars. 7 years ago
Matthew Chen dd7e429318 Skip default implementation of preferredLayoutAttributesFittingAttributes. 7 years ago
Matthew Chen 0ac1cb1e72 Cache system message text. 7 years ago
Matthew Chen db3df249bf Merge NSData categories. 7 years ago
Matthew Chen 2c9c028504 Clean up. 7 years ago
Matthew Chen db92704b50 "Bump build to 2.29.0.1." 7 years ago
Matthew Chen 6dfe36f9b5 Respond to CR. 7 years ago
Matthew Chen 9c92719ec4 Refine theme. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Matthew Chen a56a16411f Refine theme. 7 years ago
Matthew Chen a543cd5a4e Refine theme. 7 years ago
Matthew Chen 931562de33 Refine theme. 7 years ago
Matthew Chen ce4fdd5135 Refine theme. 7 years ago
Matthew Chen 9fefce94a2 Refine theme. 7 years ago
Matthew Chen d34f83b445 Refine theme. 7 years ago
Matthew Chen 069c66e5e8 Refine theme. 7 years ago
Matthew Chen 8da96e979c Refine theme. 7 years ago
Matthew Chen 4f8dbf39b5 Refine theme. 7 years ago
Matthew Chen 7437e7a6b1 Remove 'has' accessors from proto wrappers. 7 years ago
Matthew Chen 5d3b0f7939 "Bump build to 2.29.0.0." 7 years ago
Matthew Chen 1868c58037 Converge appLaunchTime. 7 years ago
Matthew Chen b3c62d91be Merge remote-tracking branch 'origin/release/2.28.1' 7 years ago
Matthew Chen 7cc8674201 Fix "save non-media attachment" crash. 7 years ago
Matthew Chen e5eda8b45d Add convenience initializers to proto wrappers. 7 years ago
Michael Kirk 0620aba3bc Add cancel button 7 years ago
Michael Kirk 9662b3cb1e Wait a week before nagging when a new release comes out 7 years ago
Michael Kirk 51b1761364 Fix crash during CollectionView thrash 7 years ago
Michael Kirk 7e5d9480b1 Add missing header file 7 years ago
Michael Kirk 2ea7e2b036 CR: clean up preferences 7 years ago
Michael Kirk ff2a5a1511 Fixup copy
// FREEBIE
7 years ago
Michael Kirk e5b3cbd00c Use StoreKit for reviews 7 years ago
Matthew Chen 21523ac522 Respond to CR. 7 years ago
Matthew Chen a5ffbdebb3 Remove Obj-c proto parser. 7 years ago
Matthew Chen a4d24c78a4 Respond to CR. 7 years ago
Matthew Chen 90002459c4 Add unit tests around proto wrappers. 7 years ago
Matthew Chen f4a11f0c6f Respond to CR. 7 years ago
Matthew Chen dc012d46e4 Migrate call proto wrappers. 7 years ago
Matthew Chen 135a1655fd Migrate call proto wrappers. 7 years ago
Matthew Chen 32d0f23b22 Migrate call proto wrappers. 7 years ago
Matthew Chen 94675e880a Migrate call proto wrappers. 7 years ago
Matthew Chen 8837e5902e Migrate call proto wrappers. 7 years ago
Matthew Chen 68241e8a0a Respond to CR. 7 years ago
Matthew Chen 34a404f589 Clean up ahead of PR. 7 years ago
Matthew Chen 379104c532 Migrate to WebRTC proto wrappers. 7 years ago
Matthew Chen 67110d0def Migrate to websocket proto wrappers. 7 years ago
Matthew Chen f795ec352e Migrate to backup proto wrappers. 7 years ago
Matthew Chen eaf59b122d Migrate to provisioning proto wrappers. 7 years ago
Matthew Chen 2fd77fcc29 Fix typo. 7 years ago
Matthew Chen 4bb0122c07 Respond to CR. 7 years ago
Matthew Chen 815ccbdcd1 Respond to CR. 7 years ago
Matthew Chen 45e782c243 Revamp orphan data cleaner. 7 years ago
Michael Kirk 882c699db3 "Bump build to 2.28.1.5." 7 years ago
Michael Kirk 01b6634ac1 synthesize appLaunchTime 7 years ago
Michael Kirk 15dfa6e979 "Bump build to 2.28.1.4." 7 years ago
Michael Kirk 9e45104eee "Bump build to 2.28.1.3." 7 years ago
Michael Kirk 5039a6a9e5 "Bump build to 2.28.1.2." 7 years ago
Matthew Chen 463addaa6c Ignore new calls in the incomplete calls job. 7 years ago
Matthew Chen faf3cd6a55 Fix lazy collapse of message cell footers. 7 years ago
Matthew Chen cea93784b1 Avoid redundant content inset updates. 7 years ago
Matthew Chen d709a02493 Clean up formatting. 7 years ago
Matthew Chen 9b45a15c35 Merge branch 'release/2.28.1' 7 years ago
Michael Kirk 0bc03b0fd4 Move seed 7 years ago
Michael Kirk df01c7e63e Update to latest YapDB (with Signal patches applied)
Applied branches:

- mkirk/invalidFinalIndices
- mkirk/upstream-unencrypted-headers

Also fixed up test suite.
7 years ago
Matthew Chen c8f33e4fc6 "Bump build to 2.28.1.1." 7 years ago
Matthew Chen 4918b8994e Delay footer collapse in new messages. 7 years ago
Matthew Chen 95cf4f5c6d Don't reserve space for timestamp in footer. 7 years ago
Matthew Chen 251eef46a2 Delay footer collapse in new messages. 7 years ago
Matthew Chen 3f47524373 Respond to CR. 7 years ago
Michael Kirk dbbccaadbe fixup block table vis a new navbar style
// FREEBIE
7 years ago
Michael Kirk 991848b364 Fix "blue navbar" for contact picker
- content flows behind navbar
- unify search bar style with rest of app

// FREEBIE
7 years ago
Matthew Chen 03a9b21cfd Respond to CR. 7 years ago
Matthew Chen 6be3d2e42d Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 4d2bdf9bd0 Respond to CR. 7 years ago
Matthew Chen 21c630c095 Ignore redundant body text view updates; cache body text view size. 7 years ago
Matthew Chen ea765437ef Improve date formatting perf. 7 years ago
Matthew Chen d6d16ed162 "Bump build to 2.28.1.0." 7 years ago
Matthew Chen 827f979282 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 77810f5918 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 2b05bbc0aa Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen f814157a9e Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen dfc39b4a1d Tidy files. 7 years ago
Matthew Chen e6bc37d941 Tidy files. 7 years ago
Matthew Chen 2c19474397 Tidy files. 7 years ago
Matthew Chen 8f55f53329 Tidy files. 7 years ago
Matthew Chen d6cb07cc4a Respond to CR. 7 years ago
Matthew Chen 579e88bdc2 Improve nullability handling for SignalAccount. 7 years ago
Matthew Chen f611abc16f Log when we change logging state. 7 years ago
Michael Kirk 103a8dc579 ubsan fixups 7 years ago
Michael Kirk 78ad597e44 Merge tag '2.28.0.15' 7 years ago
Michael Kirk 48a69c46d8 "Bump build to 2.28.0.15." 7 years ago
Michael Kirk d713c4158f sync translations 7 years ago
Matthew Chen cd6225c438 Respond to CR. 7 years ago
Matthew Chen 995c2f2a2a Refine 'new message' animations. 7 years ago
Matthew Chen 24d85898e1 Refine 'new message' animations. 7 years ago
Matthew Chen 026ef02ce5 Refine 'new message' animations. 7 years ago
Michael Kirk def8b43daa iOS9/10 fixups 7 years ago
Michael Kirk bfe1eb5503 Move reminder views into scrollable content
// FREEBIE
7 years ago
Michael Kirk 29c459fe60 Haptic feedback when changing menu action selection
// FREEBIE
7 years ago
Michael Kirk e5e5bbddc9 Menu UX
- Use longpress gesture to implement pannable tap gesture, e.g. slide between actions, select whichever one is below on touchup
- Remove swipe to dismiss, in line with System Action sheet
7 years ago
Jesse Squires 6dc74ddcaf Fix some project warnings + other fixes
- Prefer checking `.isEmpty` rather than `.count == 0` for Swift collections (can be more optimal)
- Avoid comparing `BOOL` explicitly to `NO` (considered bad practice since `BOOL` is a `signed char`)
- Specify unused `SGX_FLAGS` as `__unused` to silence warnings
7 years ago
Michael Kirk 04c00ff28b Fix letterboxed video on M68
Upstream changed how this is handled.
7 years ago
Matthew Chen 1b01e8f65f Clean up timer animation. 7 years ago
Michael Kirk 1658812102 TSan config 7 years ago
Michael Kirk 181d99d80e "Bump build to 2.28.0.14." 7 years ago
Michael Kirk 0fb3ac85a7 Sync translations 7 years ago
Michael Kirk ac461ca2d1 Fixup parser: Robust to servers various "empty" types
For base64Encoded data, sometimes the server sends "null" sometimes the server
sends an empty string.
7 years ago
Matthew Chen baf432f1ee Respond to CR. 7 years ago
Matthew Chen fa8a07abf1 Respond to CR. 7 years ago
Matthew Chen 581347a7fb Refine theme. 7 years ago
Matthew Chen 7759c9ca0f Refine theme. 7 years ago
Matthew Chen f795b12a86 Refine theme. 7 years ago
Michael Kirk bae2e8649d Dry up Parameter parsing logic 7 years ago
Michael Kirk c2ed507d66 Merge tag '2.28.0.13' 7 years ago
Michael Kirk d39906f606 CR: test malformed protos 7 years ago
Michael Kirk e5856b2ac5 CR: Add back deprecated constructor to debug list 7 years ago
Michael Kirk 1824d7dcef "Bump build to 2.28.0.13." 7 years ago
Michael Kirk 778a8aa079 sync translations 7 years ago
Michael Kirk b860dce7f9 Swift protos for Envelope 7 years ago
Michael Kirk d5ebd5a60f UBSan fixup 7 years ago
Michael Kirk 11db859e6b adapt to changes since RI 7 years ago
Michael Kirk 6e1c1a681b Merge tag '2.28.0.12' 7 years ago
Michael Kirk 6518aa24a3 "Bump build to 2.28.0.12." 7 years ago
Michael Kirk d04bb86258 sync translations 7 years ago
Michael Kirk 2d4eb7d057 remove interactive 'swipe for info' 7 years ago
Michael Kirk aba358e894 faster message actions presentation 7 years ago
Michael Kirk b42f528713 Integrate with new contact discovery endpoint
Also:
* use system cookie parsing
* add AESGCM additional authenticated data parameter

// FREEBIE
7 years ago
Michael Kirk 1d4ead080b fix color behind navbar 7 years ago
Matthew Chen bebb8ecfd1 Cycle the socket after linking a new device. 7 years ago
Matthew Chen b197e4776e Respond to CR. 7 years ago
Matthew Chen 73eb0778c0 Add unit tests around byte parser. 7 years ago
Matthew Chen 25a98554b7 Intern JSQMessagesViewController. 7 years ago
Matthew Chen 819c2b1ceb Remove Twisted Oak. 7 years ago
Matthew Chen c3d47d3323 Respond to CR. 7 years ago
Matthew Chen 904ed1549e Add unit test around remote attestation. 7 years ago
Michael Kirk 551bb5b93b ubsan fixup 7 years ago
Michael Kirk 9d279b4d85 "Bump build to 2.28.0.11." 7 years ago
Matthew Chen 88c5fc1af8 Fix message footer alignment. 7 years ago
Matthew Chen e271730f33 Ignore gestures in date breaks and unread indicators. 7 years ago
Matthew Chen 9d5af7bb2e Set sender names apart. 7 years ago
Matthew Chen 2b1f928770 Respond to CR. 7 years ago
Matthew Chen b90e406a57 Clean up ahead of PR. 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago
Matthew Chen b2b95597cc Refine views. 7 years ago
Matthew Chen 8862f9a531 Refine views. 7 years ago
Matthew Chen fcbf8d4dc2 Refine views. 7 years ago
Matthew Chen 9f9e0965d5 Refine table views. 7 years ago
Michael Kirk 90430c75c0 update ubsan 7 years ago
Matthew Chen 97eb405a9e Revert temporary changes. 7 years ago
Matthew Chen 460f7344ad Remote attestation. 7 years ago
Matthew Chen d7bb2b7505 Remote attestation. 7 years ago
Matthew Chen f3ba6d4c27 Remote attestation. 7 years ago
Michael Kirk 9e348f2a27 update ubsan 7 years ago
Nancy Mast 4ab6892e27 changed string text for MULTIDEVICE_PAIRING_MAX_DESC, ATTACHMENT_PICKER_DOCUMENTS_PICKED_DIRECTORY_FAILED_ALERT_BODY, CONTACT_FIELD_ADDRESS_POSTCODE, END_CALL_RESPONDER_IS_BUSY. changed comment for SETTINGS_INVITE_TWITTER_TEXT 7 years ago
Nancy Mast c2f7c15f72 removed jsq strings, modified MULTIDEVICE_PAIRING_MAX_RECOVERY text and comment 7 years ago
Matthew Chen 7f33236d6c Respond to CR. 7 years ago
Matthew Chen ace07ac62a Respond to CR. 7 years ago
Matthew Chen ebe87348a2 Streamline SignalRecipient. 7 years ago
Matthew Chen d14f764b50 Streamline SignalRecipient. 7 years ago
Michael Kirk ef9a0880ae Fix analyzer warnings 7 years ago
Michael Kirk baacebc956 Enable (quick) static analyzer for normal builds
// FREEBIE
7 years ago
Michael Kirk 12ef25420a Fixup SSK tests 7 years ago
Michael Kirk d591fb7f2c Fix some compiler warnings 7 years ago
Michael Kirk c19a8ce07e Fixup tests
// FREEBIE
7 years ago
Michael Kirk 1c9a47416a "Bump build to 2.28.0.10." 7 years ago
Michael Kirk 89f02a8510 sync translations 7 years ago
Michael Kirk 2b5db4fd1a Add header view to info messages.
I considered extracting this from OWSMessageCell and putting it into
ConversationCell, but that would be a pretty large change.

// FREEBIE
7 years ago
Michael Kirk a6a09f4d9f fix squashed cells on ios9/10
must specify rowHeight automatic

Furthermore, we can't mix static and automatic sizing within a single tableView
7 years ago
Michael Kirk 17e79a522a fixup audio/generic atachment margins 7 years ago
Michael Kirk c2063d8600 replace bullet with center-dot unicode
// FREEBIE
7 years ago
Michael Kirk 7b85410136 per design: MessageStatus 1pt below baseline 7 years ago
Michael Kirk 567f625902 touch instead of reload to make sure any adjacent bubbles are updated appropriately. 7 years ago
Michael Kirk 2c3f7db4e4 Only add one 'incoming message' unread indicator per foreground.
// FREEBIE
7 years ago
Michael Kirk f2f3b9eaed reload cell after removing unread indicator
// FREEBIE
7 years ago
Michael Kirk 1b78882660 per design: tweak quote corner radius
// FREEBIE
7 years ago
Michael Kirk b9f3e08e93 "Bump build to 2.28.0.9." 7 years ago
Michael Kirk 089010cc51 Sync translations 7 years ago
Óscar Morales Vivó 24f30e015a Fixed settings button margin in home view controller, also fixes land scape button image glitch. 7 years ago
Michael Kirk c53f777bc1 CR: explanatory comment 7 years ago
Michael Kirk 898d64ae1c Fix compose picker content scrolls behind navbar
// FREEBIE
7 years ago
Matthew Chen e3622739b2 Remove media thumbnail shadows. 7 years ago
Matthew Chen 15bfe44b1e Update icon for generic attachments. 7 years ago
Michael Kirk 24060c17d0 CR: proper width calculation for header view 7 years ago
Michael Kirk f33e5c019c CR: assign gutter trailing/leading in HeaderView
// FREEBIE
7 years ago
Michael Kirk fef6c64bdc decrease header spacing from 32->28.
Previous spacing was based on applying the "full width" gutter spacing twice.
7 years ago
Michael Kirk 8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
7 years ago
Michael Kirk 9df6b4bb78 Fix "contact cell too close to edge" in detail view (iOS9/iOS10)
Don't mix concepts of left/right with leading/trailing.
7 years ago
Michael Kirk 7d0733fa88 "Bump build to 2.28.0.8." 7 years ago
Michael Kirk 8984e1a717 Sync translations 7 years ago
Michael Kirk 0847c0bafb ScrollToBottom accounts for top inset
// FREEBIE
7 years ago
Matthew Chen 687efabede Respond to CR. 7 years ago
Matthew Chen 96a8df5f88 Fix "new unread indicator animation" issue. 7 years ago
Matthew Chen f69945ea20 Fix 'breaks vs. collapse' issue. 7 years ago
Michael Kirk e911de01e9 Ensure delegate is informed of dismissal
// FREEBIE
7 years ago
Michael Kirk 39bbcca738 CR: cleanup / copy tweak 7 years ago
Michael Kirk dde2fd6f33 Hide menu window when vc dismisses.
Normally this isn't possible, just being paranoid.

// FREEBIE
7 years ago
Michael Kirk 82fdd5b883 Split out generic action sheet components
Keep the message specific components separte, so we could re-use the
MenuActionsViewController.
7 years ago
Michael Kirk 093a5eaa68 don't dismiss if pan is over actionsheet 7 years ago
Michael Kirk 41af4f8c9d highlight on press 7 years ago
Michael Kirk 2606ac47f8 swipe gesture / code reorg 7 years ago
Michael Kirk 41c1c2fcd5 scroll focused view to maximize visability
// FREEBIE
7 years ago
Michael Kirk d31b91663c new icons 7 years ago
Michael Kirk ce3030917f MessageActions for info messages 7 years ago
Michael Kirk 42eb7a8d31 cleanup unused code 7 years ago